mirror of https://github.com/citusdata/citus.git
dont: don't, wont: won't, acylic: acyclic
parent
fff3866844
commit
c252811884
|
@ -353,7 +353,7 @@ FindAvailableConnection(dlist_head *connections, uint32 flags)
|
|||
|
||||
if (flags & OUTSIDE_TRANSACTION)
|
||||
{
|
||||
/* dont return connections that are used in transactions */
|
||||
/* don't return connections that are used in transactions */
|
||||
if (connection->remoteTransaction.transactionState !=
|
||||
REMOTE_TRANS_NOT_STARTED)
|
||||
{
|
||||
|
|
|
@ -646,7 +646,7 @@ AdaptiveExecutor(CitusScanState *scanState)
|
|||
/*
|
||||
* PostgreSQL takes locks on all partitions in the executor. It's not entirely
|
||||
* clear why this is necessary (instead of locking the parent during DDL), but
|
||||
* We do the same for consistency.
|
||||
* we do the same for consistency.
|
||||
*/
|
||||
LockPartitionsForDistributedPlan(distributedPlan);
|
||||
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
/*-------------------------------------------------------------------------
|
||||
*
|
||||
* directed_acylic_graph_execution_logic.c
|
||||
* directed_acyclic_graph_execution_logic.c
|
||||
*
|
||||
* Logic to run tasks in their dependency order.
|
||||
*
|
||||
|
@ -11,7 +11,7 @@
|
|||
#include "access/hash.h"
|
||||
#include "distributed/hash_helpers.h"
|
||||
|
||||
#include "distributed/directed_acylic_graph_execution.h"
|
||||
#include "distributed/directed_acyclic_graph_execution.h"
|
||||
#include "distributed/multi_physical_planner.h"
|
||||
#include "distributed/adaptive_executor.h"
|
||||
#include "distributed/worker_manager.h"
|
|
@ -16,8 +16,8 @@
|
|||
*
|
||||
*
|
||||
* Repartition queries do not begin a transaction even if we are in
|
||||
* a transaction block. As we dont begin a transaction, they wont see the
|
||||
* DDLs that happened earlier in the transaction because we dont have that
|
||||
* a transaction block. As we don't begin a transaction, they won't see the
|
||||
* DDLs that happened earlier in the transaction because we don't have that
|
||||
* transaction id with repartition queries. Therefore we error in this case.
|
||||
*
|
||||
* Copyright (c) Citus Data, Inc.
|
||||
|
@ -29,7 +29,7 @@
|
|||
#include "utils/builtins.h"
|
||||
#include "distributed/hash_helpers.h"
|
||||
|
||||
#include "distributed/directed_acylic_graph_execution.h"
|
||||
#include "distributed/directed_acyclic_graph_execution.h"
|
||||
#include "distributed/multi_physical_planner.h"
|
||||
#include "distributed/adaptive_executor.h"
|
||||
#include "distributed/worker_manager.h"
|
||||
|
|
|
@ -238,7 +238,7 @@ JoinOnColumns(Var *currentColumn, Var *candidateColumn, List *joinClauseList)
|
|||
|
||||
/*
|
||||
* Check if both join columns and both partition key columns match, since the
|
||||
* current and candidate column's can't be NULL we know they wont match if either
|
||||
* current and candidate column's can't be NULL we know they won't match if either
|
||||
* of the columns resolved to NULL above.
|
||||
*/
|
||||
if (equal(leftColumn, currentColumn) &&
|
||||
|
|
|
@ -1,14 +1,14 @@
|
|||
/*-------------------------------------------------------------------------
|
||||
*
|
||||
* directed_acylic_graph_execution.h
|
||||
* Execution logic for directed acylic graph tasks.
|
||||
* directed_acyclic_graph_execution.h
|
||||
* Execution logic for directed acyclic graph tasks.
|
||||
*
|
||||
* Copyright (c) Citus Data, Inc.
|
||||
*-------------------------------------------------------------------------
|
||||
*/
|
||||
|
||||
#ifndef DIRECTED_ACYLIC_GRAPH_EXECUTION_H
|
||||
#define DIRECTED_ACYLIC_GRAPH_EXECUTION_H
|
||||
#ifndef DIRECTED_ACYCLIC_GRAPH_EXECUTION_H
|
||||
#define DIRECTED_ACYCLIC_GRAPH_EXECUTION_H
|
||||
|
||||
#include "postgres.h"
|
||||
|
||||
|
@ -17,4 +17,4 @@
|
|||
extern void ExecuteTasksInDependencyOrder(List *allTasks, List *excludedTasks);
|
||||
|
||||
|
||||
#endif /* DIRECTED_ACYLIC_GRAPH_EXECUTION_H */
|
||||
#endif /* DIRECTED_ACYCLIC_GRAPH_EXECUTION_H */
|
|
@ -89,7 +89,7 @@ How the citus upgrade test work:
|
|||
|
||||
Note that when the version of citus changes, we should update `MASTER_VERSION` with the new version of citus otherwise that will be outdated and it will fail.
|
||||
|
||||
There is a target for citus upgrade test. We run citus upgrade tests both in normal mode and in mixed mode. In mixed mode, we dont upgrade one of the workers. `'citus.enable_version_checks' : 'false'` is used to prevent citus from giving an error for mixed mode.
|
||||
There is a target for citus upgrade test. We run citus upgrade tests both in normal mode and in mixed mode. In mixed mode, we don't upgrade one of the workers. `'citus.enable_version_checks' : 'false'` is used to prevent citus from giving an error for mixed mode.
|
||||
|
||||
To see full command list:
|
||||
|
||||
|
|
Loading…
Reference in New Issue