diff --git a/src/backend/distributed/master/master_create_shards.c b/src/backend/distributed/master/master_create_shards.c index 98e0975d8..d2c7ed441 100644 --- a/src/backend/distributed/master/master_create_shards.c +++ b/src/backend/distributed/master/master_create_shards.c @@ -198,14 +198,14 @@ CreateShardsWithRoundRobinPolicy(Oid distributedTableId, int32 shardCount, uint32 roundRobinNodeIndex = shardIndex % workerNodeCount; /* initialize the hash token space for this shard */ - int32 shardMinHashToken = INT32_MIN + (shardIndex * hashTokenIncrement); + int32 shardMinHashToken = PG_INT32_MIN + (shardIndex * hashTokenIncrement); int32 shardMaxHashToken = shardMinHashToken + (hashTokenIncrement - 1); uint64 shardId = GetNextShardId(); /* if we are at the last shard, make sure the max token value is INT_MAX */ if (shardIndex == (shardCount - 1)) { - shardMaxHashToken = INT32_MAX; + shardMaxHashToken = PG_INT32_MAX; } /* insert the shard metadata row along with its min/max values */ diff --git a/src/backend/distributed/metadata/metadata_cache.c b/src/backend/distributed/metadata/metadata_cache.c index 002cf6d79..e393289c9 100644 --- a/src/backend/distributed/metadata/metadata_cache.c +++ b/src/backend/distributed/metadata/metadata_cache.c @@ -1391,12 +1391,12 @@ HasUniformHashDistribution(ShardInterval **shardIntervalArray, for (int shardIndex = 0; shardIndex < shardIntervalArrayLength; shardIndex++) { ShardInterval *shardInterval = shardIntervalArray[shardIndex]; - int32 shardMinHashToken = INT32_MIN + (shardIndex * hashTokenIncrement); + int32 shardMinHashToken = PG_INT32_MIN + (shardIndex * hashTokenIncrement); int32 shardMaxHashToken = shardMinHashToken + (hashTokenIncrement - 1); if (shardIndex == (shardIntervalArrayLength - 1)) { - shardMaxHashToken = INT32_MAX; + shardMaxHashToken = PG_INT32_MAX; } if (DatumGetInt32(shardInterval->minValue) != shardMinHashToken || diff --git a/src/backend/distributed/planner/multi_physical_planner.c b/src/backend/distributed/planner/multi_physical_planner.c index 0617a63b6..0eb391437 100644 --- a/src/backend/distributed/planner/multi_physical_planner.c +++ b/src/backend/distributed/planner/multi_physical_planner.c @@ -4411,7 +4411,7 @@ GenerateSyntheticShardIntervalArray(int partitionCount) ShardInterval *shardInterval = CitusMakeNode(ShardInterval); /* calculate the split of the hash space */ - int32 shardMinHashToken = INT32_MIN + (shardIndex * hashTokenIncrement); + int32 shardMinHashToken = PG_INT32_MIN + (shardIndex * hashTokenIncrement); int32 shardMaxHashToken = shardMinHashToken + (hashTokenIncrement - 1); shardInterval->relationId = InvalidOid; diff --git a/src/backend/distributed/test/distribution_metadata.c b/src/backend/distributed/test/distribution_metadata.c index 6e8d0ef8e..02f7c2b13 100644 --- a/src/backend/distributed/test/distribution_metadata.c +++ b/src/backend/distributed/test/distribution_metadata.c @@ -219,8 +219,8 @@ create_monolithic_shard_row(PG_FUNCTION_ARGS) StringInfo maxInfo = makeStringInfo(); uint64 newShardId = GetNextShardId(); - appendStringInfo(minInfo, "%d", INT32_MIN); - appendStringInfo(maxInfo, "%d", INT32_MAX); + appendStringInfo(minInfo, "%d", PG_INT32_MIN); + appendStringInfo(maxInfo, "%d", PG_INT32_MAX); text *minInfoText = cstring_to_text(minInfo->data); text *maxInfoText = cstring_to_text(maxInfo->data); diff --git a/src/backend/distributed/utils/shardinterval_utils.c b/src/backend/distributed/utils/shardinterval_utils.c index ecd54f15d..7e2041621 100644 --- a/src/backend/distributed/utils/shardinterval_utils.c +++ b/src/backend/distributed/utils/shardinterval_utils.c @@ -26,9 +26,6 @@ #include "utils/memutils.h" -static int CalculateUniformHashRangeIndex(int hashedValue, int shardCount); - - /* * LowestShardIntervalById returns the shard interval with the lowest shard * ID from a list of shard intervals. @@ -311,7 +308,7 @@ FindShardInterval(Datum partitionColumnValue, DistTableCacheEntry *cacheEntry) * INVALID_SHARD_INDEX is returned). This should only happen if something is * terribly wrong, either metadata tables are corrupted or we have a bug * somewhere. Such as a hash function which returns a value not in the range - * of [INT32_MIN, INT32_MAX] can fire this. + * of [PG_INT32_MIN, PG_INT32_MAX] can fire this. */ int FindShardIntervalIndex(Datum searchedValue, DistTableCacheEntry *cacheEntry) @@ -443,13 +440,13 @@ SearchCachedShardInterval(Datum partitionColumnValue, ShardInterval **shardInter * NOTE: This function is ONLY for hash-distributed tables with uniform * hash ranges. */ -static int +int CalculateUniformHashRangeIndex(int hashedValue, int shardCount) { int64 hashedValue64 = (int64) hashedValue; /* normalize to the 0-UINT32_MAX range */ - int64 normalizedHashValue = hashedValue64 - INT32_MIN; + int64 normalizedHashValue = hashedValue64 - PG_INT32_MIN; /* size of each hash range */ int64 hashRangeSize = HASH_TOKEN_COUNT / shardCount; diff --git a/src/backend/distributed/worker/worker_partition_protocol.c b/src/backend/distributed/worker/worker_partition_protocol.c index 2aa4bcf31..be7cb4e9d 100644 --- a/src/backend/distributed/worker/worker_partition_protocol.c +++ b/src/backend/distributed/worker/worker_partition_protocol.c @@ -250,7 +250,7 @@ worker_hash_partition_table(PG_FUNCTION_ARGS) static ShardInterval ** SyntheticShardIntervalArrayForShardMinValues(Datum *shardMinValues, int shardCount) { - Datum nextShardMaxValue = Int32GetDatum(INT32_MAX); + Datum nextShardMaxValue = Int32GetDatum(PG_INT32_MAX); ShardInterval **syntheticShardIntervalArray = palloc(sizeof(ShardInterval *) * shardCount); @@ -1240,7 +1240,6 @@ HashPartitionId(Datum partitionValue, Oid partitionCollation, const void *contex FmgrInfo *comparisonFunction = hashPartitionContext->comparisonFunction; Datum hashDatum = FunctionCall1Coll(hashFunction, DEFAULT_COLLATION_OID, partitionValue); - int32 hashResult = 0; uint32 hashPartitionId = 0; if (hashDatum == 0) @@ -1250,10 +1249,8 @@ HashPartitionId(Datum partitionValue, Oid partitionCollation, const void *contex if (hashPartitionContext->hasUniformHashDistribution) { - uint64 hashTokenIncrement = HASH_TOKEN_COUNT / partitionCount; - - hashResult = DatumGetInt32(hashDatum); - hashPartitionId = (uint32) (hashResult - INT32_MIN) / hashTokenIncrement; + int hashValue = DatumGetInt32(hashDatum); + hashPartitionId = CalculateUniformHashRangeIndex(hashValue, partitionCount); } else { diff --git a/src/include/distributed/shardinterval_utils.h b/src/include/distributed/shardinterval_utils.h index 88cb9065f..ab9bdd67c 100644 --- a/src/include/distributed/shardinterval_utils.h +++ b/src/include/distributed/shardinterval_utils.h @@ -47,6 +47,7 @@ extern int CompareShardPlacementsByShardId(const void *leftElement, extern int CompareRelationShards(const void *leftElement, const void *rightElement); extern int ShardIndex(ShardInterval *shardInterval); +extern int CalculateUniformHashRangeIndex(int hashedValue, int shardCount); extern ShardInterval * FindShardInterval(Datum partitionColumnValue, DistTableCacheEntry *cacheEntry); extern int FindShardIntervalIndex(Datum searchedValue, DistTableCacheEntry *cacheEntry);