From c8839de68bc0a8d4d0fc13d68ed276fa16076da4 Mon Sep 17 00:00:00 2001 From: Jelte Fennema Date: Wed, 9 Mar 2022 14:35:23 +0100 Subject: [PATCH] Don't use cascading deletes in Citus 11 migration script (#5767) Using CASCADE in a DELETE can inadvertently delete things we don't intend to. It's safer to fail hard and make the user delete depending things manually. --- src/backend/distributed/sql/citus--10.2-4--11.0-1.sql | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/distributed/sql/citus--10.2-4--11.0-1.sql b/src/backend/distributed/sql/citus--10.2-4--11.0-1.sql index 591092a0d..f341976c9 100644 --- a/src/backend/distributed/sql/citus--10.2-4--11.0-1.sql +++ b/src/backend/distributed/sql/citus--10.2-4--11.0-1.sql @@ -31,8 +31,11 @@ #include "udfs/citus_calculate_gpid/11.0-1.sql" #include "udfs/citus_backend_gpid/11.0-1.sql" -DROP FUNCTION IF EXISTS pg_catalog.citus_dist_stat_activity() CASCADE; -DROP FUNCTION IF EXISTS pg_catalog.citus_worker_stat_activity() CASCADE; +DROP VIEW IF EXISTS pg_catalog.citus_lock_waits; +DROP VIEW IF EXISTS pg_catalog.citus_dist_stat_activity; +DROP VIEW IF EXISTS pg_catalog.citus_worker_stat_activity; +DROP FUNCTION IF EXISTS pg_catalog.citus_dist_stat_activity(); +DROP FUNCTION IF EXISTS pg_catalog.citus_worker_stat_activity(); #include "udfs/citus_dist_stat_activity/11.0-1.sql" -- a very simple helper function defined for citus_lock_waits