From c8a48c6eeefcc417ce311a91d9097598c8a8b5fd Mon Sep 17 00:00:00 2001
From: Onur Tirtir <onurcantirtir@gmail.com>
Date: Tue, 2 Feb 2021 15:12:12 +0300
Subject: [PATCH] Not try to sync metadata for local tables (#4625)

---
 src/backend/distributed/metadata/metadata_sync.c      |  5 +++++
 .../expected/alter_table_set_access_method.out        | 11 ++++++-----
 .../regress/sql/alter_table_set_access_method.sql     |  3 ++-
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/backend/distributed/metadata/metadata_sync.c b/src/backend/distributed/metadata/metadata_sync.c
index c80e2d8bc..8f507d84a 100644
--- a/src/backend/distributed/metadata/metadata_sync.c
+++ b/src/backend/distributed/metadata/metadata_sync.c
@@ -243,6 +243,11 @@ ClusterHasKnownMetadataWorkers()
 bool
 ShouldSyncTableMetadata(Oid relationId)
 {
+	if (!OidIsValid(relationId) || !IsCitusTable(relationId))
+	{
+		return false;
+	}
+
 	CitusTableCacheEntry *tableEntry = GetCitusTableCacheEntry(relationId);
 
 	bool streamingReplicated =
diff --git a/src/test/regress/expected/alter_table_set_access_method.out b/src/test/regress/expected/alter_table_set_access_method.out
index bb20565f1..54484dff7 100644
--- a/src/test/regress/expected/alter_table_set_access_method.out
+++ b/src/test/regress/expected/alter_table_set_access_method.out
@@ -492,7 +492,8 @@ SELECT * FROM mat_view ORDER BY a;
  2
 (2 rows)
 
-CREATE TABLE local(a int);
+CREATE SEQUENCE c_seq;
+CREATE TABLE local(a int, b bigserial, c int default nextval('c_seq'));
 INSERT INTO local VALUES (3);
 create materialized view m_local as select * from local;
 create view v_local as select * from local;
@@ -615,9 +616,9 @@ NOTICE:  Renaming the new table to alter_table_set_access_method.dist
 (1 row)
 
 SELECT * FROM m_local;
- a
+ a | b | c
 ---------------------------------------------------------------------
- 3
+ 3 | 1 | 1
 (1 row)
 
 SELECT * FROM m_ref;
@@ -635,9 +636,9 @@ SELECT * FROM m_dist;
 (2 rows)
 
 SELECT * FROM v_local;
- a
+ a | b | c
 ---------------------------------------------------------------------
- 3
+ 3 | 1 | 1
 (1 row)
 
 SELECT * FROM v_ref;
diff --git a/src/test/regress/sql/alter_table_set_access_method.sql b/src/test/regress/sql/alter_table_set_access_method.sql
index 02e3c6e1c..17c7438f8 100644
--- a/src/test/regress/sql/alter_table_set_access_method.sql
+++ b/src/test/regress/sql/alter_table_set_access_method.sql
@@ -156,7 +156,8 @@ CREATE MATERIALIZED VIEW mat_view AS SELECT * FROM mat_view_test;
 SELECT alter_table_set_access_method('mat_view_test','columnar');
 SELECT * FROM mat_view ORDER BY a;
 
-CREATE TABLE local(a int);
+CREATE SEQUENCE c_seq;
+CREATE TABLE local(a int, b bigserial, c int default nextval('c_seq'));
 INSERT INTO local VALUES (3);
 create materialized view m_local as select * from local;
 create view v_local as select * from local;