external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PG17 compatibility: Fix -1/Null diff in attstattarget test output (#7749) 

Changed `attstattarget` in `pg_attribute` to use `NullableDatum`,
allowing null representation for default statistics target in PostgreSQL
17.

Relevant PG commit:
6a004f1be87d34cfe51acf2fe2552d2b08a79273
6a004f1be8

```diff
 -- verify statistics is set
 SELECT c.relname, a.attstattarget
 FROM pg_attribute a
 JOIN pg_class c ON a.attrelid = c.oid AND c.relname LIKE 'test\_idx%'
 ORDER BY c.relname, a.attnum;
   relname  | attstattarget 
 -----------+---------------
  test_idx  |          4646
- test_idx2 |            -1
+ test_idx2 |              
  test_idx2 |         10000
  test_idx2 |          3737
 (4 rows)
```
pull/7922/head
Mehmet YILMAZ 2024-11-17 23:43:39 +03:00 committed by naisila
parent 7e8bff034f
commit c8d9a1bd10
2 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/regress/expected/alter_index.out
View File

@ -32,29 +32,33 @@ SELECT create_distributed_table('t2','a');
(1 row) (1 row)
-- verify statistics is set -- verify statistics is set
SELECT c.relname, a.attstattarget -- pg17 Changed `attstattarget` in `pg_attribute` to use `NullableDatum`, allowing null representation for default statistics target in PostgreSQL 17.
-- https://github.com/postgres/postgres/commit/6a004f1be87d34cfe51acf2fe2552d2b08a79273
SELECT c.relname,
CASE WHEN a.attstattarget = -1 THEN NULL ELSE a.attstattarget END AS attstattarget
FROM pg_attribute a FROM pg_attribute a
JOIN pg_class c ON a.attrelid = c.oid AND c.relname LIKE 'test\_idx%' JOIN pg_class c ON a.attrelid = c.oid AND c.relname LIKE 'test\_idx%'
ORDER BY c.relname, a.attnum; ORDER BY c.relname, a.attnum;
relname | attstattarget relname | attstattarget
--------------------------------------------------------------------- ---------------------------------------------------------------------
test_idx | 4646 test_idx | 4646
test_idx2 | -1 test_idx2 |
test_idx2 | 10000 test_idx2 | 10000
test_idx2 | 3737 test_idx2 | 3737
(4 rows) (4 rows)
\c - - - :worker_1_port \c - - - :worker_1_port
SELECT c.relname, a.attstattarget SELECT c.relname,
CASE WHEN a.attstattarget = -1 THEN NULL ELSE a.attstattarget END AS attstattarget
FROM pg_attribute a FROM pg_attribute a
JOIN pg_class c ON a.attrelid = c.oid AND c.relname SIMILAR TO 'test\_idx%\_\d%' JOIN pg_class c ON a.attrelid = c.oid AND c.relname SIMILAR TO 'test\_idx%\_\d%'
ORDER BY c.relname, a.attnum; ORDER BY c.relname, a.attnum;
relname | attstattarget relname | attstattarget
--------------------------------------------------------------------- ---------------------------------------------------------------------
test_idx2_980004 | -1 test_idx2_980004 |
test_idx2_980004 | 10000 test_idx2_980004 | 10000
test_idx2_980004 | 3737 test_idx2_980004 | 3737
test_idx2_980006 | -1 test_idx2_980006 |
test_idx2_980006 | 10000 test_idx2_980006 | 10000
test_idx2_980006 | 3737 test_idx2_980006 | 3737
test_idx_980000 | 4646 test_idx_980000 | 4646

8
src/test/regress/sql/alter_index.sql
View File

@ -23,13 +23,17 @@ ALTER INDEX test_idx2 ALTER COLUMN 2 SET STATISTICS 99999;
SELECT create_distributed_table('t2','a'); SELECT create_distributed_table('t2','a');
-- verify statistics is set -- verify statistics is set
SELECT c.relname, a.attstattarget -- pg17 Changed `attstattarget` in `pg_attribute` to use `NullableDatum`, allowing null representation for default statistics target in PostgreSQL 17.
-- https://github.com/postgres/postgres/commit/6a004f1be87d34cfe51acf2fe2552d2b08a79273
SELECT c.relname,
CASE WHEN a.attstattarget = -1 THEN NULL ELSE a.attstattarget END AS attstattarget
FROM pg_attribute a FROM pg_attribute a
JOIN pg_class c ON a.attrelid = c.oid AND c.relname LIKE 'test\_idx%' JOIN pg_class c ON a.attrelid = c.oid AND c.relname LIKE 'test\_idx%'
ORDER BY c.relname, a.attnum; ORDER BY c.relname, a.attnum;
\c - - - :worker_1_port \c - - - :worker_1_port
SELECT c.relname, a.attstattarget SELECT c.relname,
CASE WHEN a.attstattarget = -1 THEN NULL ELSE a.attstattarget END AS attstattarget
FROM pg_attribute a FROM pg_attribute a
JOIN pg_class c ON a.attrelid = c.oid AND c.relname SIMILAR TO 'test\_idx%\_\d%' JOIN pg_class c ON a.attrelid = c.oid AND c.relname SIMILAR TO 'test\_idx%\_\d%'
ORDER BY c.relname, a.attnum; ORDER BY c.relname, a.attnum;