external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Citus indent

velioglu/wo_seq_test_1
Burak Velioglu 2021-12-28 12:48:20 +03:00
parent e610a147a1
commit cc68e87903
No known key found for this signature in database
GPG Key ID: F6827E620F6549C6
7 changed files with 31 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/distributed/commands/alter_table.c
View File

@ -1354,8 +1354,8 @@ ReplaceTable(Oid sourceId, Oid targetId, List *justBeforeDropCommands,
changeDependencyFor(RelationRelationId, sequenceOid,
RelationRelationId, sourceId, targetId);
// Changing the dependency for sequence will prevent PG to have
// sequence within drop trigger
/* Changing the dependency for sequence will prevent PG to have */
/* sequence within drop trigger */
if (conversionType == UNDISTRIBUTE_TABLE)
{
ObjectAddress sequenceAddress = { 0 };

2
src/backend/distributed/commands/citus_add_local_table_to_metadata.c
View File

@ -1250,7 +1250,7 @@ FinalizeCitusLocalTableCreation(Oid relationId, List *dependentSequenceList)
}
else
{
// Mark the table as distributed only locally
/* Mark the table as distributed only locally */
bool prevDependencyCreationValue = EnableDependencyCreation;
SetLocalEnableDependencyCreation(false);
MarkObjectDistributed(&relationAddress);

2
src/backend/distributed/commands/create_distributed_table.c
View File

@ -540,7 +540,7 @@ CreateDistributedTable(Oid relationId, Var *distributionColumn, char distributio
}
else
{
// Mark the table as distributed only locally
/* Mark the table as distributed only locally */
bool prevDependencyCreationValue = EnableDependencyCreation;
SetLocalEnableDependencyCreation(false);
MarkObjectDistributed(&tableAddress);

7
src/backend/distributed/commands/dependencies.c
View File

@ -242,7 +242,7 @@ GetDependencyCreateDDLCommands(const ObjectAddress *dependency)
if (IsCitusTable(relationId) && !IsTableOwnedByExtension(relationId))
{
/* skip table metadata creation when the Citus table is owned by an extension */
// TODO: Check sequence next val type
/* TODO: Check sequence next val type */
List *commandList = NIL;
List *tableDDLCommands = GetFullTableCreationCommands(relationId,
WORKER_NEXTVAL_SEQUENCE_DEFAULTS);
@ -266,7 +266,7 @@ GetDependencyCreateDDLCommands(const ObjectAddress *dependency)
if (relKind == RELKIND_SEQUENCE)
{
// TODO: Check user name for different scenarios
/* TODO: Check user name for different scenarios */
char *userName = GetUserNameFromId(GetUserId(), false);
return DDLCommandsForSequence(dependency->objectId, userName);
}
@ -403,7 +403,8 @@ ReplicateAllDependenciesToNode(const char *nodeName, int nodePort)
ddlCommands = lcons(DISABLE_DDL_PROPAGATION, ddlCommands);
ddlCommands = lappend(ddlCommands, ENABLE_DDL_PROPAGATION);
SendCommandListToWorkerOutsideTransaction(nodeName, nodePort, CitusExtensionOwnerName(), ddlCommands);
SendCommandListToWorkerOutsideTransaction(nodeName, nodePort,
CitusExtensionOwnerName(), ddlCommands);
}

18
src/backend/distributed/metadata/node_metadata.c
View File

@ -827,7 +827,8 @@ ClearDistributedTablesFromNode(WorkerNode *workerNode)
clearDistributedTablesCommandList = list_concat(list_make1(DISABLE_DDL_PROPAGATION),
clearDistributedTablesCommandList);
clearDistributedTablesCommandList = list_concat(clearDistributedTablesCommandList, list_make1(
clearDistributedTablesCommandList = list_concat(clearDistributedTablesCommandList,
list_make1(
ENABLE_DDL_PROPAGATION));
SendCommandListToWorkerOutsideTransaction(workerNode->workerName,
@ -906,14 +907,15 @@ SetUpDistributedTableWithDependencies(WorkerNode *newWorkerNode)
* We prefer this because otherwise node activation might fail within
* transaction blocks.
*/
// TODO: Doesn't make sense to have that here as we won't handle placement metadata
// with maintenance daemon anymore
/* TODO: Doesn't make sense to have that here as we won't handle placement metadata */
/* with maintenance daemon anymore */
/* if (ClusterHasDistributedFunctionWithDistArgument())
{
SetWorkerColumnLocalOnly(newWorkerNode, Anum_pg_dist_node_hasmetadata,
BoolGetDatum(true));
TriggerMetadataSyncOnCommit();
}*/
* {
* SetWorkerColumnLocalOnly(newWorkerNode, Anum_pg_dist_node_hasmetadata,
* BoolGetDatum(true));
* TriggerMetadataSyncOnCommit();
* }*/
}
}