external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

not log in debug level in null parameters (#3718) 

The purpose of null_parameters is to make sure that citus doesn't crash
with null parameters. (The related issue is #3493.) The logs in this
file are not that important and they are flaky. The flakiness is related
to postgres part as well so it is hard to reproduce them. Therefore it
makes sense to decrease the log level.
pull/3403/head
SaitTalhaNisanci 2020-04-06 17:59:46 +03:00 committed by GitHub
parent 3d3605be80
commit cd3e499834
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 485 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

483
src/test/regress/expected/null_parameters.out
View File

File diff suppressed because it is too large Load Diff

10
src/test/regress/sql/null_parameters.sql
View File

@ -7,8 +7,10 @@ SET citus.next_shard_id TO 1680000;
CREATE TABLE text_dist_column (key text, value text); CREATE TABLE text_dist_column (key text, value text);
SELECT create_distributed_table('text_dist_column', 'key'); SELECT create_distributed_table('text_dist_column', 'key');
SET client_min_messages TO DEBUG; -- it seems that sometimes the pruning is deferred and sometimes not.
-- what we care about is that these queries don't crash and the log for this
-- one shouldn't matter. This is to prevent these test being from flaky in our CI.
SET client_min_messages to NOTICE;
PREPARE null_select_on_text AS SELECT count(*) FROM text_dist_column WHERE key = NULL; PREPARE null_select_on_text AS SELECT count(*) FROM text_dist_column WHERE key = NULL;
EXECUTE null_select_on_text; EXECUTE null_select_on_text;
@ -309,10 +311,6 @@ EXECUTE null_select_on_json_param(NULL);
EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL);
EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL);
EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL);
-- it seems that sometimes the pruning is deferred and sometimes not.
-- what we care about is that this doesn't crash and the log for this
-- one shouldn't matter. This is to prevent this test being from flaky.
SET client_min_messages to ERROR;
EXECUTE null_select_on_json_param(NULL); EXECUTE null_select_on_json_param(NULL);
SET client_min_messages TO ERROR; SET client_min_messages TO ERROR;