From d5397b3a1fdf42e3ce7fcab07102a53b75347370 Mon Sep 17 00:00:00 2001 From: Jelte Fennema Date: Tue, 1 Mar 2022 13:55:37 +0100 Subject: [PATCH] Address review --- .../citus_tests/arbitrary_configs/citus_arbitrary_configs.py | 1 - src/test/regress/citus_tests/common.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/regress/citus_tests/arbitrary_configs/citus_arbitrary_configs.py b/src/test/regress/citus_tests/arbitrary_configs/citus_arbitrary_configs.py index b5f71f945..53c6750f4 100755 --- a/src/test/regress/citus_tests/arbitrary_configs/citus_arbitrary_configs.py +++ b/src/test/regress/citus_tests/arbitrary_configs/citus_arbitrary_configs.py @@ -55,7 +55,6 @@ def run_for_config(config, lock, sql_schedule_name): if config.user == cfg.REGULAR_USER_NAME: common.create_role( config.bindir, - config.coordinator_port(), config.node_name_to_ports.values(), config.user, ) diff --git a/src/test/regress/citus_tests/common.py b/src/test/regress/citus_tests/common.py index 182c6abd3..c6e551fa1 100644 --- a/src/test/regress/citus_tests/common.py +++ b/src/test/regress/citus_tests/common.py @@ -62,7 +62,7 @@ def add_settings(abs_data_path, settings): conf_file.write(setting) -def create_role(pg_path, coordinator_port, node_ports, user_name): +def create_role(pg_path, node_ports, user_name): def create(port): command = "SELECT worker_create_or_alter_role('{}', 'CREATE ROLE {} WITH LOGIN CREATEROLE CREATEDB;', NULL)".format( user_name, user_name @@ -106,7 +106,7 @@ def start_databases(pg_path, rel_data_path, node_name_to_ports, logfile_prefix, parallel_run(start, node_name_to_ports.keys()) - # We don't want parallel shutdown, here because that will fail when it's + # We don't want parallel shutdown here because that will fail when it's # tried in this atexit call with an error like: # cannot schedule new futures after interpreter shutdown atexit.register(