external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

background task execution: fixed dereference of NULL (#7694) 

In the function TaskConcurrentCancelCheck() the pointer "task" was
utilized after checking against NULL, which can lead to dereference of
the null pointer.
To avoid the problem, added a separate handling of the case when the
pointer is null with an interruption of execution.

Fixes: #7693.

Fixes: 1f8675da4382f6e("nonblocking concurrent task execution via
background workers")

Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
pull/7810/merge
Maxim Korotkov 2025-03-05 18:07:58 +03:00 committed by GitHub
parent 26ad52713c
commit d885e1a016
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/distributed/utils/background_jobs.c
View File

@ -706,8 +706,12 @@ TaskConcurrentCancelCheck(TaskExecutionContext *taskExecutionContext)
BackgroundExecutorHashEntry *handleEntry = taskExecutionContext->handleEntry; BackgroundExecutorHashEntry *handleEntry = taskExecutionContext->handleEntry;
BackgroundTask *task = GetBackgroundTaskByTaskId(handleEntry->taskid); BackgroundTask *task = GetBackgroundTaskByTaskId(handleEntry->taskid);
taskExecutionContext->task = task; taskExecutionContext->task = task;
if (!task)
{
ereport(ERROR, (errmsg("unexpected missing task id: %ld", handleEntry->taskid)));
}
if (!task || task->status == BACKGROUND_TASK_STATUS_CANCELLING) if (task->status == BACKGROUND_TASK_STATUS_CANCELLING)
{ {
/* /*
* being in that step means that a concurrent cancel or removal happened. we should * being in that step means that a concurrent cancel or removal happened. we should