From d912cd9a9bd3df2f8da638717de7a5b73c60791a Mon Sep 17 00:00:00 2001 From: Burak Velioglu Date: Tue, 28 Dec 2021 11:17:43 +0300 Subject: [PATCH] Update todos --- src/backend/distributed/commands/dependencies.c | 4 +--- src/backend/distributed/metadata/dependency.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/backend/distributed/commands/dependencies.c b/src/backend/distributed/commands/dependencies.c index 62e8172bd..50f02ec01 100644 --- a/src/backend/distributed/commands/dependencies.c +++ b/src/backend/distributed/commands/dependencies.c @@ -59,8 +59,6 @@ EnsureDependenciesExistOnAllNodes(const ObjectAddress *target) /* collect all dependencies in creation order and get their ddl commands */ List *dependencies = GetDependenciesForObject(target); - /* TODO: Might add check for PG (not Citus) tables */ - ObjectAddress *dependency = NULL; foreach_ptr(dependency, dependencies) { @@ -257,7 +255,7 @@ GetDependencyCreateDDLCommands(const ObjectAddress *dependency) tableDDLCommand)); } - /* TODO: May need to move sequence dependencies to ActiveNode directly */ + /* TODO: May need to move sequence dependencies to ActivateNode directly */ List *sequenceDependencyCommandList = SequenceDependencyCommandList( dependency->objectId); commandList = list_concat(commandList, sequenceDependencyCommandList); diff --git a/src/backend/distributed/metadata/dependency.c b/src/backend/distributed/metadata/dependency.c index 962163ce6..2d063b625 100644 --- a/src/backend/distributed/metadata/dependency.c +++ b/src/backend/distributed/metadata/dependency.c @@ -677,7 +677,7 @@ SupportedDependencyByCitus(const ObjectAddress *address) */ if (relKind == RELKIND_COMPOSITE_TYPE || relKind == RELKIND_RELATION || - relKind == RELKIND_PARTITIONED_TABLE || /* TODO: Should check for normal tables? */ + relKind == RELKIND_PARTITIONED_TABLE || relKind == RELKIND_SEQUENCE) { return true;