From db0e4ce889366802d4aab2c58015eaf929dd3f82 Mon Sep 17 00:00:00 2001 From: Onur Tirtir Date: Thu, 29 Jul 2021 16:13:18 +0300 Subject: [PATCH] Increment command counter in FinishModifyRelation instead Seems that we always increment the command counter right after finishing metadata table modification. For this reason, it makes sense to call CommandCounterIncrement within FinishModifyRelation. --- src/backend/columnar/columnar_metadata.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/backend/columnar/columnar_metadata.c b/src/backend/columnar/columnar_metadata.c index 9d0dc2658..79c7946d2 100644 --- a/src/backend/columnar/columnar_metadata.c +++ b/src/backend/columnar/columnar_metadata.c @@ -484,8 +484,6 @@ SaveStripeSkipList(RelFileNode relfilenode, uint64 stripe, StripeSkipList *chunk FinishModifyRelation(modifyState); table_close(columnarChunk, RowExclusiveLock); - - CommandCounterIncrement(); } @@ -522,8 +520,6 @@ SaveChunkGroups(RelFileNode relfilenode, uint64 stripe, FinishModifyRelation(modifyState); table_close(columnarChunkGroup, NoLock); - - CommandCounterIncrement(); } @@ -887,8 +883,6 @@ InsertStripeMetadataRow(uint64 storageId, StripeMetadata *stripe) FinishModifyRelation(modifyState); - CommandCounterIncrement(); - table_close(columnarStripes, RowExclusiveLock); } @@ -1206,6 +1200,8 @@ FinishModifyRelation(ModifyState *state) ExecCleanUpTriggerState(state->estate); ExecResetTupleTable(state->estate->es_tupleTable, false); FreeExecutorState(state->estate); + + CommandCounterIncrement(); }