external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix multiple output version arbitrary config tests (#6744) 

With this small change, arbitrary config tests can have multiple acceptable correct outputs.

For an arbitrary config tests named `t`, now you can define `expected/t.out`, `expected/t_0.out`, `expected/t_1.out` etc and the test will succeed if the output of `sql/t.sql` is equal to any of the `t.out` or `t_{0, 1, ...}.out` files.
pull/6748/head
Gledis Zeneli 2023-03-03 21:06:59 +03:00 committed by GitHub
parent 0d401344c2
commit dc7fa0d5af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/regress/citus_tests/arbitrary_configs/citus_arbitrary_configs.py
View File

@ -151,14 +151,24 @@ def copy_test_files_with_names(test_names, sql_dir_path, expected_dir_path, conf
continue
sql_name = os.path.join("./sql", test_name + ".sql")
output_name = os.path.join("./expected", test_name + ".out")
shutil.copy(sql_name, sql_dir_path)
if os.path.isfile(output_name):
# for a test named <t>, all files:
# <t>.out, <t>_0.out, <t>_1.out ...
# are considered as valid outputs for the test
# by the testing tool (pg_regress)
# so copy such files to the testing directory
output_name = os.path.join("./expected", test_name + ".out")
alt_output_version_no = 0
while os.path.isfile(output_name):
# it might be the first time we run this test and the expected file
# might not be there yet, in that case, we don't want to error out
# while copying the file.
shutil.copy(output_name, expected_dir_path)
output_name = os.path.join(
"./expected", f"{test_name}_{alt_output_version_no}.out"
)
alt_output_version_no += 1
def run_tests(configs, sql_schedule_name):