From dde4c47d3f79234c21aa9685f86f868204640e76 Mon Sep 17 00:00:00 2001
From: Mehmet Yilmaz <mehmetyilmaz@microsoft.com>
Date: Sun, 14 Sep 2025 12:39:51 +0000
Subject: [PATCH] Add comment to clarify unexpected RECORD type handling in
 get_name_for_var_field

---
 src/backend/distributed/deparser/ruleutils_18.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/backend/distributed/deparser/ruleutils_18.c b/src/backend/distributed/deparser/ruleutils_18.c
index bd044f5e7..6c7720275 100644
--- a/src/backend/distributed/deparser/ruleutils_18.c
+++ b/src/backend/distributed/deparser/ruleutils_18.c
@@ -4880,6 +4880,13 @@ get_name_for_var_field(Var *var, int fieldno,
 		case RTE_VALUES:
 		case RTE_NAMEDTUPLESTORE:
 		case RTE_RESULT:
+
+			/*
+			 * This case should not occur: a column of a table or values list
+			 * shouldn't have type RECORD.  Fall through and fail (most
+			 * likely) at the bottom.
+			 */
+			break;
 		case RTE_SUBQUERY:
 			/* Subselect-in-FROM: examine sub-select's output expr */
 			{