external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flakiness in test

pull/7009/head
Hanefi Onaldi 2023-06-20 16:01:33 +03:00
parent 6acb4dc9f6
commit dde8e26e90
No known key found for this signature in database
GPG Key ID: F18CDB10BA0DFDC7
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/test/regress/expected/isolation_index_vs_all_on_mx.out
View File

@ -205,7 +205,7 @@ citus_remove_node
(1 row)
starting permutation: w1-start-session-level-connection w1-create-named-index w1-begin-on-worker w1-delete coord-begin coord-short-statement-timeout coord-take-lock w1-reindex deadlock-checker-call coord-rollback w1-commit-worker w1-stop-connection
starting permutation: w1-start-session-level-connection w1-create-named-index w1-begin-on-worker w1-delete coord-begin coord-take-lock w1-reindex deadlock-checker-call coord-rollback w1-commit-worker w1-stop-connection
citus_set_coordinator_host
---------------------------------------------------------------------
@ -246,9 +246,6 @@ run_commands_on_session_level_connection_to_node
step coord-begin:
BEGIN;
step coord-short-statement-timeout:
SET statement_timeout = 100;
step coord-take-lock:
LOCK TABLE dist_table IN ACCESS EXCLUSIVE MODE;
<waiting ...>

8
src/test/regress/spec/isolation_index_vs_all_on_mx.spec
View File

@ -116,11 +116,6 @@ step "coord-take-lock"
LOCK TABLE dist_table IN ACCESS EXCLUSIVE MODE;
}
step "coord-short-statement-timeout"
{
SET statement_timeout = 100;
}
session "deadlock-checker"
step "deadlock-checker-call"
@ -142,13 +137,12 @@ permutation "w1-start-session-level-connection" "w1-begin-on-worker" // open tra
"w1-stop-connection" "w2-stop-connection" // close connections to workers
"coord-print-index-count" // show indexes on coordinator
// the following permutation is expected to fail with a distributed deadlock. However, we do not detect the deadlock, and get blocked until statement_timeout.
// the following permutation is expected to fail with a distributed deadlock
permutation "w1-start-session-level-connection" // start session on worker 1 only
"w1-create-named-index" // create index on worker 1
"w1-begin-on-worker" // open transaction block on worker 1
"w1-delete" // delete from table on worker 1
"coord-begin" // open transaction on coordinator to test distributed deadlock
"coord-short-statement-timeout" // set statement timeout on coordinator to early abort deadlock check
"coord-take-lock" // take ACCESS EXCLUSIVE lock on table on coordinator, get blocked on worker 1
"w1-reindex" // reindex on worker that will acquire ACCESS EXCLUSIVE lock on table, create distributed deadlock
"deadlock-checker-call" // check that distributed deadlock is detected properly