From e0570baad66ca0bd0ea6bc266e7a1653f990c198 Mon Sep 17 00:00:00 2001
From: Naisila Puka <37271756+naisila@users.noreply.github.com>
Date: Sat, 1 Nov 2025 22:36:16 +0300
Subject: [PATCH] PG18 - Remove REINDEX SYSTEM test because of aio debug lines
 (#8305)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes #8268

PG18 added core async I/O infrastructure. Relevant PG commit:
https://github.com/postgres/postgres/commit/da72269

In `pg16.sql test`, we tested `REINDEX SYSTEM` command, which would
later cause io debug lines in a command of `multi_insert_select.sql`
test, that runs _after_ `pg16.sql` test.

"This is expected because the I/O subsystem is repopulating its internal
callback pool after heavy catalog I/O churn caused by REINDEX SYSTEM." -
chatgpt (seems right 😄)

This PR removes `REINDEX SYSTEM` test as its not crucial anyway.
`REINDEX DATABASE` is sufficient for the purpose presented in pg16.sql
test.
---
 src/test/regress/expected/pg16.out | 10 +---------
 src/test/regress/sql/pg16.sql      |  5 +----
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/src/test/regress/expected/pg16.out b/src/test/regress/expected/pg16.out
index 80c2bb3df..a172c54c0 100644
--- a/src/test/regress/expected/pg16.out
+++ b/src/test/regress/expected/pg16.out
@@ -878,6 +878,7 @@ SET search_path TO pg16;
 -- We already don't propagate these commands automatically
 -- Testing here with run_command_on_workers
 -- Relevant PG commit: https://github.com/postgres/postgres/commit/2cbc3c1
+-- Testing only DATABASE here as SYSTEM produces aio output in PG18
 REINDEX DATABASE;
 SELECT result FROM run_command_on_workers
 ($$REINDEX DATABASE$$);
@@ -887,15 +888,6 @@ SELECT result FROM run_command_on_workers
  REINDEX
 (2 rows)
 
-REINDEX SYSTEM;
-SELECT result FROM run_command_on_workers
-($$REINDEX SYSTEM$$);
- result
----------------------------------------------------------------------
- REINDEX
- REINDEX
-(2 rows)
-
 --
 -- random_normal() to provide normally-distributed random numbers
 -- adding here the same tests as the ones with random() in aggregate_support.sql
diff --git a/src/test/regress/sql/pg16.sql b/src/test/regress/sql/pg16.sql
index a57c4c5b4..bada3649c 100644
--- a/src/test/regress/sql/pg16.sql
+++ b/src/test/regress/sql/pg16.sql
@@ -521,15 +521,12 @@ SET search_path TO pg16;
 -- We already don't propagate these commands automatically
 -- Testing here with run_command_on_workers
 -- Relevant PG commit: https://github.com/postgres/postgres/commit/2cbc3c1
+-- Testing only DATABASE here as SYSTEM produces aio output in PG18
 
 REINDEX DATABASE;
 SELECT result FROM run_command_on_workers
 ($$REINDEX DATABASE$$);
 
-REINDEX SYSTEM;
-SELECT result FROM run_command_on_workers
-($$REINDEX SYSTEM$$);
-
 --
 -- random_normal() to provide normally-distributed random numbers
 -- adding here the same tests as the ones with random() in aggregate_support.sql