From e0f2c3fa5230d88e2c4778f164704a227058be04 Mon Sep 17 00:00:00 2001 From: Onder Kalaci Date: Fri, 2 Dec 2022 11:28:26 +0100 Subject: [PATCH] DROP TABLE becomes idempotent for metadata sync - t2 --- src/backend/distributed/commands/dependencies.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/backend/distributed/commands/dependencies.c b/src/backend/distributed/commands/dependencies.c index 8f7cc4594..62ca1d5f0 100644 --- a/src/backend/distributed/commands/dependencies.c +++ b/src/backend/distributed/commands/dependencies.c @@ -517,22 +517,21 @@ GetDependencyCreateDDLCommands(const ObjectAddress *dependency) static char * CreateDropTableIfExistsCommand(Oid relationId) { - char *schemaName = get_namespace_name(get_rel_namespace(relationId)); - char *relationName = get_rel_name(relationId); - const char *quotedRelName = quote_qualified_identifier(schemaName, relationName); + char *relationName = generate_qualified_relation_name(relationId); + StringInfo workerDropQuery = makeStringInfo(); - appendStringInfo(workerDropQuery, "SELECT worker_drop_sequence_dependency('%s');", - quotedRelName); + appendStringInfo(workerDropQuery, "SELECT worker_drop_sequence_dependency(%s);", + quote_literal_cstr(relationName)); if (IsForeignTable(relationId)) { - appendStringInfo(workerDropQuery, DROP_FOREIGN_TABLE_COMMAND, quotedRelName); + appendStringInfo(workerDropQuery, DROP_FOREIGN_TABLE_COMMAND, relationName); } else { - appendStringInfo(workerDropQuery, DROP_REGULAR_TABLE_COMMAND, quotedRelName); + appendStringInfo(workerDropQuery, DROP_REGULAR_TABLE_COMMAND, relationName); } appendStringInfoString(workerDropQuery, ";");