From e12d97def2a200fc24af7343c2a5ff23bcd96de2 Mon Sep 17 00:00:00 2001 From: Jelte Fennema Date: Tue, 29 Nov 2022 10:00:06 +0100 Subject: [PATCH] Fix flakyness in multi_metadata_access (#6524) Sometimes multi_metadata_access failed like this in CI: ```diff AND ext.extname = 'citus' AND nsp.nspname = 'pg_catalog' AND NOT has_table_privilege(pg_class.oid, 'select'); oid --------------------------- - pg_dist_authinfo pg_dist_clock_logical_seq + pg_dist_authinfo (2 rows) ``` Source: https://app.circleci.com/pipelines/github/citusdata/citus/28784/workflows/e462f118-eb64-4a3f-941a-e04115334f9b/jobs/883443 This fixes that by ordering the column. --- src/test/regress/expected/multi_metadata_access.out | 5 +++-- src/test/regress/sql/multi_metadata_access.sql | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/test/regress/expected/multi_metadata_access.out b/src/test/regress/expected/multi_metadata_access.out index 654364f17..0503f2fc7 100644 --- a/src/test/regress/expected/multi_metadata_access.out +++ b/src/test/regress/expected/multi_metadata_access.out @@ -15,8 +15,9 @@ WHERE AND classid ='pg_class'::regclass AND ext.extname = 'citus' AND nsp.nspname = 'pg_catalog' - AND NOT has_table_privilege(pg_class.oid, 'select'); - oid + AND NOT has_table_privilege(pg_class.oid, 'select') +ORDER BY 1; + oid --------------------------------------------------------------------- pg_dist_authinfo pg_dist_clock_logical_seq diff --git a/src/test/regress/sql/multi_metadata_access.sql b/src/test/regress/sql/multi_metadata_access.sql index 9b595979d..1b03f0bfb 100644 --- a/src/test/regress/sql/multi_metadata_access.sql +++ b/src/test/regress/sql/multi_metadata_access.sql @@ -18,7 +18,8 @@ WHERE AND classid ='pg_class'::regclass AND ext.extname = 'citus' AND nsp.nspname = 'pg_catalog' - AND NOT has_table_privilege(pg_class.oid, 'select'); + AND NOT has_table_privilege(pg_class.oid, 'select') +ORDER BY 1; RESET role;