address couple of Colm's comments and also to enable compilation and tests

pull/7675/head
Ibrahim Halatci 2025-06-23 13:35:54 +00:00
parent 06224c3654
commit e18857998f
3 changed files with 1 additions and 7 deletions

View File

@ -3558,8 +3558,7 @@ get_update_query_targetlist_def(Query *query, List *targetList,
else if (!tle->resjunk) else if (!tle->resjunk)
{ {
int paramid = 0; int paramid = 0;
if (saw_junk) Assert(!saw_junk)
elog(ERROR, "out of order target list");
paramid = GetParamId((Node *) tle->expr); paramid = GetParamId((Node *) tle->expr);
if (paramid < previous_paramid) if (paramid < previous_paramid)

View File

@ -1082,11 +1082,6 @@ ReorderInsertSelectTargetLists(Query *originalQuery, RangeTblEntry *insertRte,
TargetEntry *newSubqueryTargetEntry = NULL; TargetEntry *newSubqueryTargetEntry = NULL;
AttrNumber originalAttrNo = get_attnum(insertRelationId, AttrNumber originalAttrNo = get_attnum(insertRelationId,
oldInsertTargetEntry->resname); oldInsertTargetEntry->resname);
Node *expr;
/* we need to explore the underlying expression */
expr = (Node *) oldInsertTargetEntry->expr;
expr = strip_implicit_coercions(expr);
/* we need to explore the underlying expression */ /* we need to explore the underlying expression */
Node *expr = strip_implicit_coercions((Node *) oldInsertTargetEntry->expr); Node *expr = strip_implicit_coercions((Node *) oldInsertTargetEntry->expr);