From e34dd6b134f1549fabd2562ec6a94dc6d84e8a56 Mon Sep 17 00:00:00 2001 From: Mehmet Yilmaz Date: Wed, 5 Mar 2025 10:42:46 +0000 Subject: [PATCH] Fix variable declaration style in MakeNextValExprForIdentity function and clean up regression test output for issue 7887 --- .../distributed/planner/insert_select_planner.c | 3 +-- src/test/regress/expected/issue_7887.out | 11 ++--------- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/backend/distributed/planner/insert_select_planner.c b/src/backend/distributed/planner/insert_select_planner.c index 09d119722..05b2a9c2b 100644 --- a/src/backend/distributed/planner/insert_select_planner.c +++ b/src/backend/distributed/planner/insert_select_planner.c @@ -1237,7 +1237,6 @@ ReorderInsertSelectTargetLists(Query *originalQuery, RangeTblEntry *insertRte, Expr * MakeNextValExprForIdentity(Oid seq_relid) { - Oid nextval_oid; Const *seq_const = makeConst( REGCLASSOID, /* type for regclass */ @@ -1250,7 +1249,7 @@ MakeNextValExprForIdentity(Oid seq_relid) ); List *func_args = list_make1(seq_const); - nextval_oid = LookupFuncName( + Oid nextval_oid = LookupFuncName( list_make1(makeString("nextval")), 1, (Oid[]) { REGCLASSOID }, diff --git a/src/test/regress/expected/issue_7887.out b/src/test/regress/expected/issue_7887.out index 2d495d74a..13defadca 100644 --- a/src/test/regress/expected/issue_7887.out +++ b/src/test/regress/expected/issue_7887.out @@ -106,13 +106,6 @@ ORDER BY table_name, id; local2_bydefault | 5000 | yyyyy | 2 (8 rows) +-- Cleanup +SET client_min_messages TO WARNING; DROP SCHEMA issue_7887 CASCADE; -NOTICE: drop cascades to 8 other objects -DETAIL: drop cascades to table local1_102010 -drop cascades to table reference1 -drop cascades to table reference1_102008 -drop cascades to table local2_102009 -drop cascades to table local2 -drop cascades to table local1 -drop cascades to table local2_bydefault_102011 -drop cascades to table local2_bydefault