Address feedback

pull/1092/head
Murat Tuncer 2017-01-06 12:01:04 +03:00
parent 205f6563fa
commit e35f4c836d
1 changed files with 15 additions and 12 deletions

View File

@ -121,7 +121,9 @@ master_remove_node(PG_FUNCTION_ARGS)
EnsureSuperUser(); EnsureSuperUser();
hasShardPlacements = NodeHasActiveShardPlacements(nodeNameString, nodePort); hasShardPlacements = NodeHasActiveShardPlacements(nodeNameString, nodePort);
if (hasShardPlacements && force) if (hasShardPlacements)
{
if (force)
{ {
ereport(NOTICE, (errmsg("Node %s:%d has active shard placements. Some " ereport(NOTICE, (errmsg("Node %s:%d has active shard placements. Some "
"queries may fail after this operation. Use " "queries may fail after this operation. Use "
@ -130,11 +132,12 @@ master_remove_node(PG_FUNCTION_ARGS)
nodeNameString, nodePort, nodeNameString, nodeNameString, nodePort, nodeNameString,
nodePort))); nodePort)));
} }
else if (hasShardPlacements) else
{ {
ereport(ERROR, (errmsg("you cannot remove a node which has active " ereport(ERROR, (errmsg("you cannot remove a node which has active "
"shard placements"))); "shard placements")));
} }
}
workerNode = FindWorkerNode(nodeNameString, nodePort); workerNode = FindWorkerNode(nodeNameString, nodePort);