From e7cce40e6e87a6c2497f80d2ac7c7d822aa75587 Mon Sep 17 00:00:00 2001
From: Hadi Moshayedi <hadi@moshayedi.net>
Date: Wed, 26 Feb 2020 07:17:32 -0800
Subject: [PATCH] Address pykello's feedback

---
 src/backend/distributed/planner/shard_pruning.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/backend/distributed/planner/shard_pruning.c b/src/backend/distributed/planner/shard_pruning.c
index 1566cf9eb..c896595b3 100644
--- a/src/backend/distributed/planner/shard_pruning.c
+++ b/src/backend/distributed/planner/shard_pruning.c
@@ -636,6 +636,7 @@ SimplifyPruningTree(PruningTreeNode *node, PruningTreeNode *parent)
 	/* Boolean operator with single (recognized/unknown) constraint gets simplified */
 	if (ConstraintCount(node) <= 1)
 	{
+		Assert(node->childBooleanNodes == NIL);
 		parent->validConstraints = list_concat(parent->validConstraints,
 											   node->validConstraints);
 		parent->hasInvalidConstraints = parent->hasInvalidConstraints ||
@@ -1898,8 +1899,8 @@ CreatePruningNode(BoolExprType boolop)
 {
 	PruningTreeNode *node = palloc0(sizeof(PruningTreeNode));
 	node->boolop = boolop;
-	node->childBooleanNodes = NULL;
-	node->validConstraints = NULL;
+	node->childBooleanNodes = NIL;
+	node->validConstraints = NIL;
 	node->hasInvalidConstraints = false;
 	return node;
 }