Clean up & address rest of comments

Makefile

@@ -10,9 +10,6 @@ ifeq (,$(wildcard Makefile.global))
 endif
 
 include Makefile.global
-# directories with source files
-SUBDIRS +=  $(citus_top_builddir)/src/backend/columnar/safeclib
-ENSURE_SUBDIRS_EXIST := $(shell mkdir -p $(SUBDIRS))
 all: extension
 
 

src/backend/columnar/Makefile

@@ -3,12 +3,12 @@ citus_top_builddir = ../../..
 safestringlib_srcdir = $(citus_abs_top_srcdir)/vendor/safestringlib
 SUBDIRS = . safeclib
 SUBDIRS +=
+ENSURE_SUBDIRS_EXIST := $(shell mkdir -p $(SUBDIRS))
 OBJS += \
 	$(patsubst $(citus_abs_srcdir)/%.c,%.o,$(foreach dir,$(SUBDIRS), $(sort $(wildcard $(citus_abs_srcdir)/$(dir)/*.c))))
 
 MODULE_big = columnar
 
-
 PG_CPPFLAGS += -I$(libpq_srcdir) -I$(safestringlib_srcdir)/include
 
 include $(citus_top_builddir)/Makefile.global

src/backend/distributed/Makefile

@@ -36,12 +36,12 @@ all:
 
 NO_PGXS = 1
 
-SHLIB_LINK += $(libpq)
+SHLIB_LINK = $(libpq)
 SHLIB_LINK_INTERNAL += -L../columnar -l:columnar.so
 override enable_rpath = yes
 include $(citus_top_builddir)/Makefile.global
 
-rpathdir = $(shell $(PG_CONFIG) --libdir):$(shell $(PG_CONFIG) --pkglibdir)
+rpathdir := $(shell $(PG_CONFIG) --libdir):$(shell $(PG_CONFIG) --pkglibdir)
 
 # make sure citus_version.o is recompiled whenever any change is made to the binary or any
 # other artifact being installed to reflect the correct gitref for every build

src/test/regress/Makefile

@@ -192,8 +192,6 @@ check-operations: all
 	-- $(MULTI_REGRESS_OPTS) --schedule=$(citus_abs_srcdir)/operations_schedule $(EXTRA_TESTS)
 
 check-columnar:
-	ldd /usr/lib/postgresql/13/lib/citus.so
-	readelf -d /usr/lib/postgresql/13/lib/citus.so
 	$(pg_regress_multi_check) --load-extension=citus \
 	-- $(MULTI_REGRESS_OPTS) --schedule=$(citus_abs_srcdir)/columnar_schedule $(EXTRA_TESTS)