From ef49e8ba04db4ecd340643ac084c608f42a8f1c5 Mon Sep 17 00:00:00 2001
From: Onder Kalaci <onderkalaci@gmail.com>
Date: Mon, 6 Apr 2020 12:28:17 +0200
Subject: [PATCH] Improve readability

---
 .../distributed/connection/shared_connection_stats.c   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/backend/distributed/connection/shared_connection_stats.c b/src/backend/distributed/connection/shared_connection_stats.c
index a6033294f..b2bf4ef7e 100644
--- a/src/backend/distributed/connection/shared_connection_stats.c
+++ b/src/backend/distributed/connection/shared_connection_stats.c
@@ -35,6 +35,8 @@
 
 #define REMOTE_CONNECTION_STATS_COLUMNS 4
 
+#define ADJUST_POOLSIZE_AUTOMATICALLY 0
+#define DISABLE_CONNECTION_THROTTLING -1
 
 /*
  * The data structure used to store data in shared memory. This data structure is only
@@ -205,7 +207,7 @@ RemoveAllSharedConnectionEntriesForNode(char *hostname, int port)
 int
 GetMaxSharedPoolSize(void)
 {
-	if (MaxSharedPoolSize == 0)
+	if (MaxSharedPoolSize == ADJUST_POOLSIZE_AUTOMATICALLY)
 	{
 		return MaxConnections;
 	}
@@ -246,7 +248,7 @@ WaitOrErrorForSharedConnection(const char *hostname, int port)
 bool
 TryToIncrementSharedConnectionCounter(const char *hostname, int port)
 {
-	if (GetMaxSharedPoolSize() == -1)
+	if (GetMaxSharedPoolSize() == DISABLE_CONNECTION_THROTTLING)
 	{
 		/* connection throttling disabled */
 		return true;
@@ -322,7 +324,7 @@ IncrementSharedConnectionCounter(const char *hostname, int port)
 {
 	SharedConnStatsHashKey connKey;
 
-	if (GetMaxSharedPoolSize() == -1)
+	if (GetMaxSharedPoolSize() == DISABLE_CONNECTION_THROTTLING)
 	{
 		/* connection throttling disabled */
 		return;
@@ -368,7 +370,7 @@ DecrementSharedConnectionCounter(const char *hostname, int port)
 {
 	SharedConnStatsHashKey connKey;
 
-	if (GetMaxSharedPoolSize() == -1)
+	if (GetMaxSharedPoolSize() == DISABLE_CONNECTION_THROTTLING)
 	{
 		/* connection throttling disabled */
 		return;