From f19feb742c02286a2c907bdb2843b6b2c02e1a7e Mon Sep 17 00:00:00 2001 From: Hadi Moshayedi Date: Tue, 12 Mar 2019 14:50:18 -0700 Subject: [PATCH] Remove never assigned colocatedRelation from CreateDistributedTable (#2479) --- .../commands/create_distributed_table.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/backend/distributed/commands/create_distributed_table.c b/src/backend/distributed/commands/create_distributed_table.c index 0184a422c..3c5a779b7 100644 --- a/src/backend/distributed/commands/create_distributed_table.c +++ b/src/backend/distributed/commands/create_distributed_table.c @@ -323,8 +323,6 @@ CreateDistributedTable(Oid relationId, Var *distributionColumn, char distributio Oid colocatedTableId = InvalidOid; bool localTableEmpty = false; - Relation colocatedRelation = NULL; - replicationModel = AppropriateReplicationModel(distributionMethod, viaDeprecatedAPI); /* @@ -358,13 +356,7 @@ CreateDistributedTable(Oid relationId, Var *distributionColumn, char distributio */ if (viaDeprecatedAPI) { - /* - * We exit early but there is no need to close colocatedRelation. Because - * if viaDeprecatedAPI is true, we never open colocatedRelation in the first - * place. - */ - Assert(colocatedRelation == NULL); - + Assert(colocateWithTableName == NULL); return; } @@ -417,11 +409,6 @@ CreateDistributedTable(Oid relationId, Var *distributionColumn, char distributio CopyLocalDataIntoShards(relationId); } } - - if (colocatedRelation != NULL) - { - relation_close(colocatedRelation, NoLock); - } }