From f3a391b80f25961c10e24990a737ad07e3cdded6 Mon Sep 17 00:00:00 2001 From: Nitish Upreti Date: Thu, 23 Jun 2022 22:14:44 -0700 Subject: [PATCH] Bug fix --- src/backend/distributed/operations/isolate_shards.c | 2 +- src/backend/distributed/operations/shard_split.c | 6 +++--- src/backend/distributed/operations/worker_split_copy_udf.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/backend/distributed/operations/isolate_shards.c b/src/backend/distributed/operations/isolate_shards.c index ff01a5ac6..c6d2a9131 100644 --- a/src/backend/distributed/operations/isolate_shards.c +++ b/src/backend/distributed/operations/isolate_shards.c @@ -560,7 +560,7 @@ SplitOffCommandList(ShardInterval *sourceShard, ShardInterval *splitOffShard) * commands in parallel. Finally, it sends commit messages to all connections * and close them. */ -void +static void ExecuteCommandListOnPlacements(List *commandList, List *placementList) { List *workerConnectionList = NIL; diff --git a/src/backend/distributed/operations/shard_split.c b/src/backend/distributed/operations/shard_split.c index 69eb20bcf..ecd201720 100644 --- a/src/backend/distributed/operations/shard_split.c +++ b/src/backend/distributed/operations/shard_split.c @@ -570,10 +570,10 @@ CreateSplitCopyCommand(ShardInterval *sourceShardSplitInterval, StringInfo splitCopyInfoRow = makeStringInfo(); appendStringInfo(splitCopyInfoRow, - "ROW(%lu, %lu, %lu, %u)::citus.split_copy_info", + "ROW(%lu, %d, %d, %u)::citus.split_copy_info", splitChildShardInterval->shardId, - splitChildShardInterval->minValue, - splitChildShardInterval->maxValue, + DatumGetInt32(splitChildShardInterval->minValue), + DatumGetInt32(splitChildShardInterval->maxValue), destinationWorkerNode->nodeId); appendStringInfo(splitCopyInfoArray, "%s", splitCopyInfoRow->data); diff --git a/src/backend/distributed/operations/worker_split_copy_udf.c b/src/backend/distributed/operations/worker_split_copy_udf.c index e4419ed39..aff3e1239 100644 --- a/src/backend/distributed/operations/worker_split_copy_udf.c +++ b/src/backend/distributed/operations/worker_split_copy_udf.c @@ -98,7 +98,7 @@ ParseSplitCopyInfoDatum(Datum splitCopyInfoDatum, SplitCopyInfo **splitCopyInfo) "destination_shard_min_value for split_copy_info cannot be null."))); } char *destinationMinHash = text_to_cstring(DatumGetTextP(minValueDatum)); - copyInfo->destinationShardMinHashValue = pg_strtoint64(destinationMinHash); + copyInfo->destinationShardMinHashValue = pg_strtoint32(destinationMinHash); Datum maxValueDatum = GetAttributeByName(dataTuple, "destination_shard_max_value", &isnull); @@ -108,7 +108,7 @@ ParseSplitCopyInfoDatum(Datum splitCopyInfoDatum, SplitCopyInfo **splitCopyInfo) "destination_shard_max_value for split_copy_info cannot be null."))); } char *destinationMaxHash = text_to_cstring(DatumGetTextP(maxValueDatum)); - copyInfo->destinationShardMaxHashValue = pg_strtoint64(destinationMaxHash); + copyInfo->destinationShardMaxHashValue = pg_strtoint32(destinationMaxHash); Datum nodeIdDatum = GetAttributeByName(dataTuple, "destination_shard_node_id", &isnull);