external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Consider foreign keys between reference tables (#5659) 

On #5071, we avoid edge cases, but below there are foreign key constraints as well

This commit makes sure we cover those as well
velioglu/temp_two_pro^2
Önder Kalacı 2022-01-28 13:38:14 +01:00 committed by GitHub
parent a40679139b
commit f68ac4a7cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/backend/distributed/utils/reference_table_utils.c
View File

@ -350,22 +350,6 @@ ReplicateReferenceTableShardToNode(ShardInterval *shardInterval, char *nodeName,
List *ddlCommandList = List *ddlCommandList =
CopyShardCommandList(shardInterval, srcNodeName, srcNodePort, includeData); CopyShardCommandList(shardInterval, srcNodeName, srcNodePort, includeData);
List *shardPlacementList = ShardPlacementListIncludingOrphanedPlacements(shardId);
ShardPlacement *targetPlacement = SearchShardPlacementInList(shardPlacementList,
nodeName, nodePort);
if (targetPlacement != NULL)
{
if (targetPlacement->shardState == SHARD_STATE_ACTIVE)
{
/* We already have the shard, nothing to do */
return;
}
ereport(ERROR, (errmsg(
"Placement for reference table \"%s\" on node %s:%d is not active. This should not be possible, please report this as a bug",
get_rel_name(shardInterval->relationId), nodeName,
nodePort)));
}
ereport(NOTICE, (errmsg("Replicating reference table \"%s\" to the node %s:%d", ereport(NOTICE, (errmsg("Replicating reference table \"%s\" to the node %s:%d",
get_rel_name(shardInterval->relationId), nodeName, get_rel_name(shardInterval->relationId), nodeName,
nodePort))); nodePort)));
@ -573,6 +557,18 @@ ReplicateAllReferenceTablesToNode(char *nodeName, int nodePort)
List *shardIntervalList = LoadShardIntervalList(referenceTableId); List *shardIntervalList = LoadShardIntervalList(referenceTableId);
ShardInterval *shardInterval = (ShardInterval *) linitial(shardIntervalList); ShardInterval *shardInterval = (ShardInterval *) linitial(shardIntervalList);
List *shardPlacementList =
ShardPlacementListIncludingOrphanedPlacements(shardInterval->shardId);
ShardPlacement *targetPlacement =
SearchShardPlacementInList(shardPlacementList, nodeName, nodePort);
if (targetPlacement != NULL &&
targetPlacement->shardState == SHARD_STATE_ACTIVE)
{
/* We already have the shard, nothing to do */
continue;
}
referenceShardIntervalList = lappend(referenceShardIntervalList, referenceShardIntervalList = lappend(referenceShardIntervalList,
shardInterval); shardInterval);
} }