From e1fe8d60b48d4d4be82822906f178576a9331d91 Mon Sep 17 00:00:00 2001 From: Onder Kalaci Date: Fri, 20 Sep 2019 11:02:50 +0200 Subject: [PATCH] Make sure that functions are also listed in SupportedDependencyByCitus We've recently merged two commits, db5d03931d1b07479707bb53e35f973056216ca2 and eccba1d4c33f31085abc2aea189110a95c4010c4, which actually operates on the very similar places. It turns out that we've an integration issue, where master_add_node() fails to replicate the functions to newly added node. --- src/backend/distributed/metadata/dependency.c | 5 +++++ .../expected/isolation_ensure_dependency_activate_node.out | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/backend/distributed/metadata/dependency.c b/src/backend/distributed/metadata/dependency.c index 8a0d6d69a..9da3432a1 100644 --- a/src/backend/distributed/metadata/dependency.c +++ b/src/backend/distributed/metadata/dependency.c @@ -339,6 +339,11 @@ SupportedDependencyByCitus(const ObjectAddress *address) return true; } + case OCLASS_PROC: + { + return true; + } + case OCLASS_TYPE: { switch (get_typtype(address->objectId)) diff --git a/src/test/regress/expected/isolation_ensure_dependency_activate_node.out b/src/test/regress/expected/isolation_ensure_dependency_activate_node.out index a7bc9b1d1..c79f53108 100644 --- a/src/test/regress/expected/isolation_ensure_dependency_activate_node.out +++ b/src/test/regress/expected/isolation_ensure_dependency_activate_node.out @@ -1974,7 +1974,7 @@ count run_command_on_workers (localhost,57637,t,1) -(localhost,57638,t,0) +(localhost,57638,t,1) master_remove_node @@ -2103,7 +2103,7 @@ count run_command_on_workers (localhost,57637,t,1) -(localhost,57638,t,0) +(localhost,57638,t,1) master_remove_node