When we use PROCESS_UTILITY_TOPLEVEL it causes some problems when
combined with other extensions such as pg_audit. With this commit we use
PROCESS_UTILITY_QUERY in the codebase to fix those problems.
(cherry picked from commit dcf54eaf2a)
Conflicts:
src/backend/distributed/commands/alter_table.c
src/backend/distributed/commands/cascade_table_operation_for_connected_relations.c
src/backend/distributed/executor/local_executor.c
src/backend/distributed/utils/role.c
src/backend/distributed/worker/worker_create_or_replace.c
src/backend/distributed/worker/worker_data_fetch_protocol.c
DESCRIPTION: Alter role only works for citus managed roles
Alter role was implemented before we implemented good role management that hooks into the object propagation framework. This is a refactor of all alter role commands that have been implemented to
- be on by default
- only work for supported roles
- make the citus extension owner a supported role
Instead of distributing the alter role commands for roles at the beginning of the node activation role it now _only_ executes the alter role commands for all users in all databases and in the current database.
In preparation of full role support small refactors have been done in the deparser.
Earlier tests targeting other roles than the citus extension owner have been either slightly changed or removed to be put back where we have full role support.
Fixes#2549
SaitTalhaNisanci
Nils Dijk
Jelte Fennema
Halil Ozan Akgul