citus

Commit Graph

Author	SHA1	Message	Date
Sait Talha Nisanci	510535f558	address feedback	2020-07-13 19:45:02 +03:00
Sait Talha Nisanci	d97d03ec65	use ActivePrimaryNodeList to include coordinator ActiveReadableWorkerNodeList doesn't include coordinator, however if coordinator is added as a worker, we should also include that while planning. The current methods are very easily misusable and this requires a refactoring to make the distinction between methods that include coordinator and that don't very explicit as they can introduce subtle/major bugs pretty easily.	2020-07-13 19:20:15 +03:00
Jelte Fennema	ab01571c9e	Fix crash with single node dummy placement (#3993 ) Static analysis found an issue where we could dereference `NULL`, because `CreateDummyPlacement` could return `NULL` when there were no workers. This PR changes it so that it never returns `NULL`, which was intended by @marcocitus when doing this change: https://github.com/citusdata/citus/pull/3887/files#r438136433 While adding tests for citus on a single node I also added some more basic tests and it turns out we error out on repartition joins. This has been present since `shouldhaveshards` was introduced and is not trivial to fix. So I created a separate issue for this: https://github.com/citusdata/citus/issues/3996	2020-07-08 17:11:25 +02:00

Author

SHA1

Message

Date

Sait Talha Nisanci

510535f558

address feedback

2020-07-13 19:45:02 +03:00

Sait Talha Nisanci

d97d03ec65

use ActivePrimaryNodeList to include coordinator

ActiveReadableWorkerNodeList doesn't include coordinator, however if
coordinator is added as a worker, we should also include that while
planning. The current methods are very easily misusable and this
requires a refactoring to make the distinction between methods that
include coordinator and that don't very explicit as they can introduce
subtle/major bugs pretty easily.

2020-07-13 19:20:15 +03:00

Jelte Fennema

ab01571c9e

Fix crash with single node dummy placement (#3993 )

Static analysis found an issue where we could dereference `NULL`, because 
`CreateDummyPlacement` could return `NULL` when there were no workers. This
PR changes it so that it never returns `NULL`, which was intended by 
@marcocitus when doing this change: https://github.com/citusdata/citus/pull/3887/files#r438136433

While adding tests for citus on a single node I also added some more basic
tests and it turns out we error out on repartition joins. This has been
present since `shouldhaveshards` was introduced and is not trivial to fix.
So I created a separate issue for this: https://github.com/citusdata/citus/issues/3996

2020-07-08 17:11:25 +02:00

3 Commits (61bc47e6a8339fc15b7caed631f72d5db06403b5)