Commit Graph

3363 Commits (9d7e601e1d597b235836ced232dc9918cbf072b6)

Author SHA1 Message Date
gindibay 9d7e601e1d Fixes review notes 2023-11-21 23:36:32 +03:00
gindibay ed3ebf2296 Removes unnecessary comment change 2023-11-21 20:22:02 +03:00
gindibay a747699b0d Removes duplicated includes 2023-11-21 20:20:42 +03:00
gindibay 752c2ee441 Fixes indentation 2023-11-21 19:52:57 +03:00
gindibay 3dd4735e6e Fixes runtime errors 2023-11-21 19:40:44 +03:00
gindibay a1ab60f5ad Merge branch 'main' into alter_database_additional_options 2023-11-20 14:40:52 +03:00
Gürkan İndibay dc93ca8913
Update src/backend/distributed/commands/database.c
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-21 16:50:40 +03:00
Gürkan İndibay 3b556cb5ed
Adds create / drop database propagation support (#7240)
DESCRIPTION: Adds support for propagating `CREATE`/`DROP` database

In this PR, create and drop database support is added.

For CREATE DATABASE:
* "oid" option is not supported
* specifying "strategy" to be different than "wal_log" is not supported
* specifying "template" to be different than "template1" is not
supported

The last two are because those are not saved in `pg_database` and when
activating a node, we cannot assume what parameters were provided when
creating the database.

And "oid" is not supported because whether user specified an arbitrary
oid when creating the database is not saved in pg_database and we want
to avoid from oid collisions that might arise from attempting to use an
auto-assigned oid on workers.

Finally, in case of node activation, GRANTs for the database are also
propagated.

---------

Co-authored-by: Jelte Fennema-Nio <github-tech@jeltef.nl>
Co-authored-by: Jelte Fennema-Nio <jelte.fennema@microsoft.com>
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-21 16:43:51 +03:00
gindibay c123fc38ec Fixes indentation 2023-11-20 00:57:38 +03:00
gindibay 2207846d48 Fixes warning 2023-11-20 00:36:53 +03:00
Gürkan İndibay 7794aab38c
Merge branch 'create_alter_database' into alter_database_additional_options 2023-11-20 11:16:21 +03:00
Naisila Puka 0d1f18862b
Propagates SECURITY LABEL ON ROLE stmt (#7304)
We propagate `SECURITY LABEL [for provider] ON ROLE rolename IS
labelname` to the worker nodes.
We also make sure to run the relevant `SecLabelStmt` commands on a
newly added node by looking at roles found in `pg_shseclabel`.

See official docs for explanation on how this command works:
https://www.postgresql.org/docs/current/sql-security-label.html
This command stores the role label in the `pg_shseclabel` catalog table.

This commit also fixes the regex string in
`check_gucs_are_alphabetically_sorted.sh` script such that it escapes
the dot. Previously it was looking for all strings starting with "citus"
instead of "citus." as it should.

To test this feature, I currently make use of a special GUC to control
label provider registration in PG_init when creating the Citus extension.
2023-11-16 13:12:30 +03:00
gindibay 58bb165145 Removes unnecessary comments 2023-11-16 10:19:00 +03:00
gindibay da72cd3cf1 Fixes quotes for db columns 2023-11-16 10:03:02 +03:00
gindibay c63f124c93 Fixes indentation 2023-11-16 09:08:45 +03:00
gindibay 1cdae74a4c Fixes review notes 2023-11-16 08:45:20 +03:00
gindibay ed9021ca90 Merge branch 'main' of https://github.com/citusdata/citus into create_alter_database 2023-11-16 04:37:01 +03:00
gindibay 8443ae36e7 Fixes indentation 2023-11-16 02:59:32 +03:00
gindibay 95572c5ada Adds EnableCreateDatabasePropagation flag check 2023-11-16 02:58:56 +03:00
gindibay b474d98e5c Removes log 2023-11-15 23:09:35 +03:00
gindibay bb2b7ae9da Adds logs for test 2023-11-15 23:02:21 +03:00
gindibay a68587391c Fixes indentation 2023-11-15 21:32:28 +03:00
gindibay 772a13dc7c Removes SendDatabaseGrantSyncCommands 2023-11-15 21:32:01 +03:00
gindibay 9b6511ad10 Fixes indentation 2023-11-15 20:57:27 +03:00
gindibay e18c4400dc Removes unnecessary logs 2023-11-15 20:48:17 +03:00
gindibay 144ede3bf0 Adds GUC check for db grant sync 2023-11-15 20:45:13 +03:00
gindibay 37681eaed0 Fixes comment on code 2023-11-15 17:01:42 +03:00
gindibay 931514b0f7 Fixes indentation 2023-11-15 16:41:38 +03:00
gindibay 6f838e6e88 Fixes indentation 2023-11-15 16:34:02 +03:00
gindibay eb46d9399b Fixes warning on compile 2023-11-15 16:26:14 +03:00
gindibay 9a558bdece Adds datacl propagation 2023-11-15 16:04:26 +03:00
gindibay cf019b858c Adds static declarations 2023-11-14 10:21:23 +03:00
gindibay c1e9335fb7 Adds distributed check in metadata syncing 2023-11-14 09:01:00 +03:00
Gürkan İndibay 7780101619
Update src/backend/distributed/commands/database.c
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-13 19:00:40 +03:00
Gürkan İndibay 1e044a217d
Update src/backend/distributed/deparser/deparse_database_stmts.c
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-13 19:00:01 +03:00
Gürkan İndibay a956786bd8
Update src/backend/distributed/deparser/deparse_database_stmts.c
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-13 18:59:48 +03:00
Gürkan İndibay 32df3313d4
Update src/backend/distributed/metadata/metadata_sync.c
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-13 18:59:36 +03:00
Onur Tirtir c1dce6fc2b commit 2023-11-13 18:02:31 +03:00
Gürkan İndibay 7e15939e50
Update src/backend/distributed/commands/database.c
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-13 17:15:11 +03:00
gindibay fcdea98edd Removes drop in citus_internal_db_command udf 2023-11-13 15:58:09 +03:00
gindibay a9977e8840 Moves validation to preprocess for createdb 2023-11-13 15:49:19 +03:00
gindibay 712fd8ebf3 Fixes comments 2023-11-13 14:23:37 +03:00
gindibay 3731c45c29 Fixes drop force option 2023-11-13 14:19:19 +03:00
gindibay 52c9e92544 Adds IsAnyObjectDistributed check for db 2023-11-13 13:44:08 +03:00
Gürkan İndibay 8728871cc3
Apply suggestions from code review
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
2023-11-13 14:56:24 +03:00
Onur Tirtir 1a80181a9c indent 2023-11-13 13:42:11 +03:00
Onur Tirtir 69217678b3 allow wal_log option only if it's set to default 2023-11-13 12:16:08 +03:00
gindibay a35cae0ed7 Fixes review issues 2023-11-13 12:07:40 +03:00
Onur Tirtir f5a3f4d351 Merge remote-tracking branch 'origin/create_alter_database' into create_alter_database 2023-11-13 11:43:51 +03:00
Onur Tirtir 2ca6e2c358 indent 2023-11-13 11:43:31 +03:00