Commit Graph

5517 Commits (ad67942cda702424ca05d7c9e0218041af3ee667)

Author SHA1 Message Date
Burak Velioglu a348b6b097
Comment out failing test 2021-12-28 16:28:28 +03:00
Burak Velioglu cc68e87903
Citus indent 2021-12-28 12:48:20 +03:00
Burak Velioglu e610a147a1
Remove unnecessary comments on tests 2021-12-28 11:37:02 +03:00
Burak Velioglu d912cd9a9b
Update todos 2021-12-28 11:27:12 +03:00
Burak Velioglu cfe3f97faf
Create shell always for dist and reference table 2021-12-28 11:08:27 +03:00
Burak Velioglu d18525a906
Create shell always for local table 2021-12-28 10:58:35 +03:00
Burak Velioglu 416196b9be
Unmark dropped tabled on worker 2021-12-28 10:52:31 +03:00
Burak Velioglu 880533a609
Divide object and metadata handling 2021-12-27 18:14:51 +03:00
Önder Kalacı d33650d1c1
Record if any partitioned Citus tables during upgrade (#5555)
With Citus 11, the default behavior is to sync the metadata.
However, partitioned tables created pre-Citus 11 might have
index names that are not compatiable with metadata syncing.

See https://github.com/citusdata/citus/issues/4962 for the
details.

With this commit, we record the existence of partitioned tables
such that we can fix it later if any exists.
2021-12-27 03:33:34 -08:00
Halil Ozan Akgül c43b6613d0
Merge pull request #5576 from citusdata/fix_metadata_sync_fails_on_multi_truncate
Fix metadata sync fails on multi_truncate
2021-12-27 14:08:18 +03:00
Halil Ozan Akgul 0c292a74f5 Fix metadata sync fails on multi_truncate 2021-12-27 13:54:53 +03:00
Önder Kalacı c9127f921f
Avoid round trips while fixing index names (#5549)
With this commit, fix_partition_shard_index_names()
works significantly faster.

For example,

32 shards, 365 partitions, 5 indexes drop from ~120 seconds to ~44 seconds
32 shards, 1095 partitions, 5 indexes drop from ~600 seconds to ~265 seconds

`queryStringList` can be really long, because it may contain #partitions * #indexes entries.

Before this change, we were actually going through the executor where each command
in the query string triggers 1 round trip per entry in queryStringList.

The aim of this commit is to avoid the round-trips by creating a single query string.

I first simply tried sending `q1;q2;..;qn` . However, the executor is designed to
handle `q1;q2;..;qn` type of query executions via the infrastructure mentioned
above (e.g., by tracking the query indexes in the list and doing 1 statement
per round trip).

One another option could have been to change the executor such that only track
the query index when `queryStringList` is provided not with queryString
including multiple `;`s . That is (a) more work (b) could cause weird edge
cases with failure handling (c) felt like coding a special case in to the executor
2021-12-27 10:29:37 +01:00
Halil Ozan Akgül e3d1a42f81
Merge pull request #5574 from citusdata/fix_metadata_sync_fails_on_multi_function_evaluation
Fix metadata sync fails on multi_function_evaluation
2021-12-27 10:53:04 +03:00
Halil Ozan Akgul bb636e6a29 Fix metadata sync fails on multi_function_evaluation 2021-12-24 19:32:58 +03:00
Halil Ozan Akgül 7e851d2b9b
Merge pull request #5553 from citusdata/fix_metadata_sync_fails_on_multi_sequence_default
Fix metadata sync fails on multi_sequence_default and multi_name_lengths
2021-12-24 17:33:37 +03:00
Halil Ozan Akgul 70e68d5312 Fix metadata sync fails on multi_name_lengths 2021-12-24 14:33:32 +03:00
Halil Ozan Akgul 5c2fb06322 Fix metadata sync fails on multi_sequence_default 2021-12-24 14:33:32 +03:00
Hanefi Onaldi caffaa8517
Merge pull request #5561 from citusdata/improve-circleci-config 2021-12-24 13:20:50 +03:00
Hanefi Onaldi 9ad29e5a9d
Improve CircleCI configs
- Parameterize PG versions
- Use single parens for consistency
- Fix spacing issues
- Remove unsupported attributes
- Compact check-style steps
- Parameterize PG versions for upgrade tests
2021-12-24 13:10:27 +03:00
Halil Ozan Akgül 7f82400352
Merge pull request #5558 from citusdata/turn_metadata_sync_on_in_multi_metadata_sync
Turn metadata sync on in multi_metadata_sync
2021-12-24 11:05:25 +03:00
Halil Ozan Akgul b9c06a6762 Turn metadata sync on in multi_metadata_sync 2021-12-24 10:58:13 +03:00
Hanefi Onaldi 479b2da740 Fix one flaky failure test 2021-12-23 20:11:45 +03:00
Ahmet Gedemenli 63626d4995
Merge pull request #5468 from citusdata/propagate-foreign-server-ops
Propagate foreign server ops
2021-12-23 19:04:52 +03:00
Ahmet Gedemenli 042d45b263 Propagate foreign server ops 2021-12-23 17:54:04 +03:00
Burak Velioglu 6598a23963
Dependency update 2021-12-23 17:46:37 +03:00
Onur Tirtir 61b5fb1cfc
Run failure_test_helpers in base schedule (#5559) 2021-12-23 12:54:12 +01:00
Talha Nisanci e196d23854
Refactor AttributeEquivalenceId (#5006) 2021-12-23 13:19:02 +03:00
Hanefi Onaldi 76176caea7 Fix typo s/exlusive/exclusive/ 2021-12-23 01:35:01 +03:00
Burak Velioglu 48c5ce8960
Dist table refactor 2021-12-23 00:16:38 +03:00
Burak Velioglu a448ca01bc
Add TODOs 2021-12-22 21:40:04 +03:00
Burak Velioglu 6705f0c612
Undistributed removed sequences while undistributing table 2021-12-22 20:26:02 +03:00
Hanefi Onaldi 1af8ca8f7c
Fix statical analysis findings (#5550) 2021-12-22 18:16:11 +03:00
Burak Velioglu 81a6cb47d6
Merge branch 'master' into velioglu/table_wo_seq_prototype 2021-12-22 11:24:40 +03:00
Burak Velioglu d66f1243bf
Object distribution change 2021-12-22 11:19:34 +03:00
Burak Velioglu 9fe1c9646d
Uncomment test 2021-12-21 22:31:45 +03:00
Burak Velioglu 50f52101b8
Remove metadata object from ref table prop 2021-12-21 22:27:36 +03:00
Burak Velioglu 9fec89d70b
Citus_disable_node 2021-12-21 21:36:32 +03:00
Ahmet Gedemenli d5a969b055
Merge pull request #5540 from citusdata/fix-function-signature-generation
Fix function signature generation
2021-12-21 19:25:41 +03:00
Ahmet Gedemenli 8e4ff34a2e Do not include return table params in the function arg list
(cherry picked from commit 90928cfd74)

Fix function signature generation

Fix comment typo

Add test for worker_create_or_replace_object

Add test for recreating distributed functions with OUT/TABLE params

Add test for recreating distributed function that returns setof int

Fix test output

Fix comment
2021-12-21 19:01:42 +03:00
Burak Velioglu 2e61c3e6b8
Add todos 2021-12-20 15:44:01 +03:00
Burak Velioglu ab29b939b2
Indentation fix 2021-12-20 12:39:03 +03:00
Burak Velioglu 303c7e230e
Ensure dependency craetion on for adding/activating node 2021-12-20 12:28:43 +03:00
Burak Velioglu b9d1ab38af
Move shell table creation out 2021-12-18 21:28:24 +03:00
Burak Velioglu 3d828bc7b6
Sync metadata first before propagating any 2021-12-18 20:25:09 +03:00
Marco Slot 80f41e94c0
Merge pull request #4945 from citusdata/marcocitus/set-transaction 2021-12-18 11:38:37 +01:00
Marco Slot 2eef71ccab Propagate SET TRANSACTION commands 2021-12-18 11:31:39 +01:00
Halil Ozan Akgül 2108410a40
Merge pull request #5535 from citusdata/turn_metadata_sync_on_in_add_corrdinator
Turn metadata sync on in add_coordinator, foreign_key_to_reference_ta…
2021-12-17 18:05:43 +03:00
Burak Velioglu f66b1d5116
Fix list creation 2021-12-17 17:17:49 +03:00
Halil Ozan Akgul 46f718c76d Turn metadata sync on in add_coordinator, foreign_key_to_reference_table and replicate_reference_tables_to_coordinator 2021-12-17 16:33:25 +03:00
Halil Ozan Akgül c3195f75a5
Merge pull request #5545 from citusdata/turn_ddl_propagation_off_on_multi_copy
Turn ddl propagation off in worker on multi_copy
2021-12-17 16:29:13 +03:00