Commit Graph

2595 Commits (c582eb89c8ab1947aa8f19e1af6a09cdbd04512c)

Author SHA1 Message Date
Hadi Moshayedi 32ecb6884c Test ROLLBACK TO SAVEPOINT with multi-shard CTE failures 2019-05-01 09:33:43 -07:00
Hadi Moshayedi aafd22dffa Fix savepoint rollback for INSERT INTO ... SELECT. 2019-05-01 09:33:43 -07:00
Hadi Moshayedi b69a762e0b Fix savepoint rollback after multi-shard update failure. 2019-05-01 09:33:43 -07:00
Jason Petersen 5b98f26984
Merge pull request #2669 from citusdata/fix_self_strncmp
Fix self strncmp

cr: @marcocitus
2019-04-30 15:18:58 -05:00
Jason Petersen 71d5d1c865 Enable variable shadowing warnings; fix all
Rather than wait for another place like the previous commit to bite us,
I think we should turn on this warning.
2019-04-30 13:24:25 -06:00
Jason Petersen 1125fc9da0 Fix self-strncmp in ConstrIsFKToReferenceTable
Make the function do what I assume was intended.
2019-04-30 13:24:25 -06:00
Hadi Moshayedi 885d48f87d
Merge pull request #2690 from citusdata/fix_diff
Normalize test results and expected files before comparing them.
2019-04-30 09:44:37 -08:00
Hadi Moshayedi a9f7c1e8cb Normalize test result/expected files before doing diff. 2019-04-30 10:19:23 -07:00
Hadi Moshayedi 4cb8ed0f9a
Merge pull request #2664 from citusdata/fix-ActivePlacementList
Don't schedule tasks on inactive nodes.
2019-04-26 10:11:58 -07:00
Hadi Moshayedi c9b1d9c2d1 Check all placements aren't inactive 2019-04-26 10:04:55 -07:00
Hadi Moshayedi 7b1d03772d Don't schedule tasks on inactive nodes. 2019-04-26 10:04:54 -07:00
Önder Kalacı 116c255d3d
Merge pull request #2683 from citusdata/order_by_fix_5
Add ORDER BYs to multi_subquery and subqueries_deep tests
2019-04-25 10:52:10 +02:00
Onder Kalaci 82813a8796 Add ORDER BYs to multi_subquery and subqueries_deep tests 2019-04-24 13:36:11 +03:00
Önder Kalacı 796141334d
Merge pull request #2677 from citusdata/implicitly_order_returning
Sort output of RETURNING
2019-04-24 11:24:42 +02:00
Onder Kalaci 004f28e18c Sort output of RETURNING
The feature is only intended for getting consistent outputs for the regression tests.

RETURNING does not have any ordering gurantees and with unified executor, the ordering
of query executions on the shards are also becoming unpredictable. Thus, we're enforcing
ordering when a GUC is set.

We implicitly add an `ORDER BY` something equivalent of
	`
	  RETURNING expr1, expr2, .. ,exprN
	  ORDER BY expr1, expr2, .. ,exprN
	`

As described in the code comments as well, this is probably not the most
performant approach we could implement. However, since we're only
targeting regression tests, I don't see any issues with that. If we
decide to expand this to a feature to users, we should revisit the
implementation and improve the performance.
2019-04-24 11:51:19 +03:00
Önder Kalacı 6362c40865
Merge pull request #2678 from citusdata/order_by_another
Add some more ORDER BYs
2019-04-24 09:56:32 +02:00
Onder Kalaci 64b323d9eb Add ORDER BY to set_operations 2019-04-23 11:51:58 +03:00
Onder Kalaci 913ffc9dcd Add ORDER BY to multi_subquery_in_where_clause 2019-04-23 11:46:00 +03:00
Önder Kalacı 41f98f9c02
Merge pull request #2671 from citusdata/fix_more_orderbys
Fix more order bys
2019-04-18 08:31:16 +02:00
Onder Kalaci 753163b4d8 Be less verbose for printing worker ports in intermediate_results 2019-04-17 14:57:20 +03:00
Onder Kalaci b3af5b2cc4 Add order by multi_mx_modifications 2019-04-17 14:57:20 +03:00
Onder Kalaci a159bd9aed Add order by window_functions 2019-04-17 14:57:20 +03:00
Jason Petersen bcf393eea8
Merge pull request #2651 from citusdata/fix_constraint_naming
Address constraint naming issue

cr: @pykello
2019-04-16 14:32:18 -06:00
Jason Petersen 4b9519e7d6 Check for non-extended constraint before extending
This will only apply to DROP and VALIDATE commands; see the lengthy
comment in multi_create_table_constraints.sql for more explanation.
2019-04-15 23:14:21 -06:00
Jason Petersen 5a017c684c Add repro case for #2484 2019-04-15 23:14:11 -06:00
Önder Kalacı 5e9dd629a2
Merge pull request #2661 from citusdata/add_orderby_subquery
Add order by subquery_complex_target_list
2019-04-11 13:08:04 +02:00
Onder Kalaci 6d81fc518c Add order by subquery_complex_target_list 2019-04-10 19:55:41 +03:00
Hadi Moshayedi 1706813dd7
Merge pull request #2659 from citusdata/fix_more_order_bys
Add missing ORDER BYs
2019-04-09 14:00:22 -07:00
Onder Kalaci 58e90ad60d Add order by multi_outer_join 2019-04-09 12:53:57 +03:00
Onder Kalaci 298e95c441 Add order by multi_shard_update_delete 2019-04-09 12:41:46 +03:00
Onder Kalaci 6a8e2c260a Add order by multi_insert_select 2019-04-09 12:28:57 +03:00
Onder Kalaci af096a898c Add order by subquery_and_cte 2019-04-09 12:19:10 +03:00
Onder Kalaci 56a1a39fd4 Add order by multi_subquery_complex_queries 2019-04-09 12:12:26 +03:00
Onder Kalaci 4effa8c1f8 Add order by multi_schema_support 2019-04-09 11:52:08 +03:00
Önder Kalacı 9c097c9f01
Merge pull request #2657 from citusdata/get_ready_for_unified_executor_order_bys
Make sure that the regression tests are resistant to execution order changes
2019-04-08 10:54:20 +02:00
Onder Kalaci 92e87738dd Make sure that the regression test output is durable to different execution orders
Mostly add order bys and suppress worker node ports in the test
outputs.
2019-04-08 11:48:08 +03:00
Jason Petersen 358ca53696 Separate follower tests and enable core dumps 2019-04-08 01:05:36 -06:00
Jason Petersen 25eece427f Remove Travis config, etc. 2019-04-07 22:44:08 -06:00
Önder Kalacı 085b3dd6cb
Merge pull request #2656 from citusdata/get_ready_for_unified_executor
Rename MultiConnectionState to MultiConnectionPollState
2019-04-05 15:38:23 +02:00
Onder Kalaci 7d872a343a Rename MultiConnectionState to MultiConnectionPollState 2019-04-05 11:50:11 +03:00
Önder Kalacı 87db7a7578
Merge pull request #2647 from citusdata/fix_alloca_bug
Ensure that stack resizing logic works expected
2019-04-03 12:24:14 +02:00
Onder Kalaci fb38dc3136 Ensure that stack resizing logic works expected
This commit has two goals:

(a) Ensure to access both edges of the allocated stack
(b) Ensure that any compiler optimizations to prevent the
    function optimized away.

Stack size after the patch:
 sudo grep -A 1 stack /proc/2119/smaps
7ffe305a6000-7ffe307a9000 rw-p 00000000 00:00 0                          [stack]
Size:               2060 kB

Stack size before the patch:
 sudo grep -A 1 stack /proc/3610/smaps
7fff09957000-7fff09978000 rw-p 00000000 00:00 0                          [stack]
Size:                132 kB
2019-04-03 10:58:19 +03:00
Burak Velioglu 4a982358a6
Merge pull request #2644 from citusdata/citus-8.2.0-changelog-1553759261
Bump citus to 8.2.0
2019-03-28 14:48:18 +03:00
Burak Velioglu c5a7827b48 Add changelog entry for 8.2.0 2019-03-28 13:45:17 +03:00
Murat Tuncer e803eb8a02
Merge pull request #2631 from citusdata/fix_column_alias
Fix column references to aliased joins
2019-03-26 13:17:56 +03:00
Murat Tuncer 1424f75ec9 Support columns referencing an aliased joins
We used to rely on PG function flatten_join_alias_vars
to resolve actual columns referenced in target entry list.

The function goes deep and finds the actual relation. This logic
usually works fine. However, when joins are given an alias, inner
relation names are not visible to target entry entry. Thus relation
resolving should stop when we the target entry column refers an
rte of an aliased join.

We stopped using PG function and provided our own flatten function.
2019-03-26 09:46:22 +03:00
Jason Petersen f218549572
Merge pull request #2640 from citusdata/fix_bad_pruning
Address unsafe coercion removal in pruning logic

cr: @onderkalaci
2019-03-25 23:05:41 -05:00
Jason Petersen 4c7f78bd7e Code review feedback 2019-03-25 22:07:27 -05:00
Jason Petersen 6a0dc7756e Formatting fixes
Noticed a lot of weird lines wrapped at 80; our standard is 90.
2019-03-22 20:32:19 -06:00
Jason Petersen 6acf52660c Always coerce RHS of pruning op to part. key type
Our assumption that strip_implicit_coercions would leave us with a bi-
nary-compatible type to that of the partition key was wrong. Instead,
we should ensure the RHS of the comparison we perform is proactively
coerced into a compatible type (at least binary compatible).
2019-03-22 20:32:19 -06:00