Commit Graph

5632 Commits (c9681d543972a835598866d2086546472586535d)

Author SHA1 Message Date
Burak Velioglu c9681d5439
Add break seq-table dependency 2022-01-25 00:23:58 +03:00
Burak Velioglu 8a3e92c569
Merge branch 'master' into velioglu/table_wo_seq_prototype 2022-01-24 23:28:54 +03:00
Onur Tirtir ff3913ad99
Copy errmsg for distributed deadlock error into heap (#5641)
multi_log_hook() hook is called by EmitErrorReport() when emitting the
ereport either to frontend or to the server logs. And some callers of
EmitErrorReport() (e.g.: errfinish()) seems to assume that string fields
of given ErrorData object needs to be freed. For this reason, we copy the
message into heap here.

I don't think we have faced with such a problem before but it seems worth
fixing as it is theoretically possible due to the reasoning above.
2022-01-24 06:27:41 -08:00
Burak Velioglu 94ccc8b7b5
Rename sequence instead of drop 2022-01-24 17:05:12 +03:00
Ahmet Gedemenli 152e512aa9
Merge pull request #5642 from citusdata/refactor-GenerateGrantOnSchemaStmtForRights
Refactor GenerateGrantOnSchemaStmtForRights
2022-01-24 12:43:42 +03:00
Burak Velioglu 524ee83a9a
Address reviews 2022-01-24 12:21:22 +03:00
Ahmet Gedemenli c838fb428f Refactor GenerateGrantOnSchemaStmtForRights 2022-01-24 11:31:59 +03:00
Burak Velioglu 3c9aa360f5
Change detachpartition nodewide object commands 2022-01-23 00:01:02 +03:00
Burak Velioglu 368e4dbb74
Move truncate trigger 2022-01-22 23:51:23 +03:00
Burak Velioglu bee36628a1
Use GetFullTableCreationCommands 2022-01-22 22:47:53 +03:00
Ahmet Gedemenli 577224cf23
Merge pull request #5630 from citusdata/multi_colocation_utils-turn-mx-on
Turn mx on for test: multi_colocation_utils
2022-01-21 19:48:00 +03:00
Ahmet Gedemenli e6fc0c6f36 Turn mx on for test: multi_colocation_utils 2022-01-21 19:31:47 +03:00
Burak Velioglu ccea041d6a
Address reviews 2022-01-21 17:52:41 +03:00
Onur Tirtir 4dc38e9e3d
Use EnsureCompatibleLocalExecutionState instead (#5640) 2022-01-21 15:37:59 +01:00
Burak Velioglu 8a5c8c449f
Address reviews 2022-01-21 12:54:18 +03:00
Ahmet Gedemenli a2b05f0d28
Merge pull request #5639 from citusdata/fix-tagetcolocation-typo
Fix typo: taget/target
2022-01-21 10:53:42 +03:00
Ahmet Gedemenli 8647682c11 Fix typo: taget/target 2022-01-21 10:35:56 +03:00
Burak Velioglu 46b4b55c7b
Fix style 2022-01-21 01:09:38 +03:00
Burak Velioglu 3bb1a1fe6c
Merge branch 'master' into velioglu/table_wo_seq_prototype 2022-01-21 01:09:20 +03:00
Burak Velioglu 86bcb7bfdd
Reorder metadata sync commands 2022-01-21 00:41:21 +03:00
Burak Velioglu 9c470ed6d4
Add delete metadata commands back 2022-01-20 17:57:48 +03:00
Onur Tirtir 0244d3f206
Merge pull request #5636 from citusdata/drop-tg-utils
Drop ruleutils copied for triggers & statistics

While reading trigger related parts of our code-base, realized that
we actually don't need to copy & paste underlying worker functions
from pg/ruleutils.c since higher level functions for those two are
anyway exposed as SQL callables, so we can delete more than ~1k lines
of code from our ruleutils_x.c files.
2022-01-20 17:35:26 +03:00
Onur Tirtir 181111b84f Drop ruleutils copied for statistics 2022-01-20 17:28:19 +03:00
Onur Tirtir 7b59295af2 Drop ruleutils copied for triggers 2022-01-20 17:28:19 +03:00
Burak Velioglu da3a0f4cdd
Combine metadata logic 2022-01-20 17:03:50 +03:00
Burak Velioglu 632d7b8038
Move sync node metadata to above 2022-01-20 14:30:28 +03:00
Burak Velioglu 0932ea9a46
Address reviews 2022-01-20 14:19:09 +03:00
Önder Kalacı ddf3c9ed32
Merge pull request #5633 from citusdata/make_minimal_work_again
Fix check-minimal
2022-01-20 11:54:18 +01:00
Önder Kalacı e8ba9dd9d3
Merge branch 'master' into make_minimal_work_again 2022-01-20 11:48:53 +01:00
Teja Mupparti 54862f8c22 (1) Functions will be delegated even when present in the scope of an explicit
BEGIN/COMMIT transaction block or in a UDF calling another UDF.
(2) Prohibit/Limit the delegated function not to do a 2PC (or any work on a
remote connection).
(3) Have a safety net to ensure the (2) i.e. we should block the connections
from the delegated procedure or make sure that no 2PC happens on the node.
(4) Such delegated functions are restricted to use only the distributed argument
value.

Note: To limit the scope of the project we are considering only Functions(not
procedures) for the initial work.

DESCRIPTION: Introduce a new flag "force_delegation" in create_distributed_function(),
which will allow a function to be delegated in an explicit transaction block.

Fixes #3265

Once the function is delegated to the worker, on that node during the planning

distributed_planner()
TryToDelegateFunctionCall()
CheckDelegatedFunctionExecution()
EnableInForceDelegatedFuncExecution()
Save the distribution argument (Constant)
ExecutorStart()
CitusBeginScan()
IsShardKeyValueAllowed()
Ensure to not use non-distribution argument.

ExecutorRun()
AdaptiveExecutor()
StartDistributedExecution()
EnsureNoRemoteExecutionFromWorkers()
Ensure all the shards are local to the node in the remoteTaskList.
NonPushableInsertSelectExecScan()
InitializeCopyShardState()
EnsureNoRemoteExecutionFromWorkers()
Ensure all the shards are local to the node in the placementList.

This also fixes a minor issue: Properly handle expressions+parameters in distribution arguments
2022-01-19 16:43:33 -08:00
Burak Velioglu f3225dbacc
Fix tests 2022-01-20 02:30:12 +03:00
Burak Velioglu fe996dd8a4
Keep adding missing ones vol4 2022-01-20 02:21:52 +03:00
Burak Velioglu 29b401b7d0
Keep adding ... 2022-01-20 02:05:33 +03:00
Burak Velioglu ea3063e6d2
Check extension owner once 2022-01-20 01:58:32 +03:00
Burak Velioglu 05b4711962
Use function to get inter table relation 2022-01-20 01:47:37 +03:00
Burak Velioglu c08220594f
Keep adding missing tables 2022-01-20 01:33:55 +03:00
Burak Velioglu 3dbaf5886b
Address reviews 2022-01-20 01:17:26 +03:00
Burak Velioglu 54f70e6e49
Add other missing old tables 2022-01-20 01:14:30 +03:00
Burak Velioglu a46ae3bee0
Fix style 2022-01-20 01:05:06 +03:00
Burak Velioglu d93b46559e
Rename metadata to node metadata on multiple points 2022-01-20 01:02:58 +03:00
Burak Velioglu 09764d6db3
Add objects table manually to tests 2022-01-20 00:51:18 +03:00
Burak Velioglu 09cfb24b16
Update should sync check
src/backend/distributed/test/distributed_intermediate_results-29ca979d.o.tmp
2022-01-20 00:31:06 +03:00
Burak Velioglu f509cd6660
Revert it back 2022-01-20 00:02:14 +03:00
Burak Velioglu fc36de02ba
Move sync check on create dist table 2022-01-19 23:53:13 +03:00
Burak Velioglu 72caebec3a
Use func to get dep def list 2022-01-19 23:50:27 +03:00
Burak Velioglu 97a1720a17
Address reviews 2022-01-19 23:31:14 +03:00
Onder Kalaci 7f30222c90 Fix check-minimal
It seems like we broke check-minimal with the refactor on #5486

This commit fixes the minor issue
2022-01-19 16:21:59 +01:00
Ahmet Gedemenli 65ab34810b
Merge pull request #5628 from citusdata/turn-mx-on-test-citus-local-tables
Turn mx on for test file citus_local_tables in multi-1 schedule
2022-01-19 14:39:28 +03:00
Burak Velioglu 065db645b9
Move table related part out from metadata 2022-01-19 14:27:13 +03:00
Ahmet Gedemenli 9e6ebe4826 Turn mx on for test file citus_local_tables, on multi-1 schedule 2022-01-19 13:55:51 +03:00