Commit Graph

5084 Commits (d50b3d8f9dee6aa7da2c7a5e1d06b2bc7e41cf90)

Author SHA1 Message Date
Nils Dijk d50b3d8f9d add 14beta3 to CI 2021-08-25 16:20:19 +03:00
Halil Ozan Akgul 99e7baeb49 Removes password outputs from alter_role_propagation tests 2021-08-25 16:18:33 +03:00
Sait Talha Nisanci e56e9cc1e7 Add alternative output for multi_deparse_function
Postgres tightened up its checks for invalid GUC names hence we started
to get an alternative output for one of our tests. We add an alternative
output since the file is relatively small.

Commit on PG:
3db826bd55cd1df0dd8c3d811f8e5b936d7ba1e4
2021-08-25 16:18:33 +03:00
Sait Talha Nisanci a76aec21f4 Add shard relation to pState in localCopy
CopyFrom expects an AccessShareLock on the table. Instead of adding an
explicit lock, we do it how postgres is doing, which is to use
addRangeTableEntryForRelation.

Commit:
c532d15dddff14b01fe9ef1d465013cb8ef186df
2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 3a64b552b9 Add alternative output for window_functions 2021-08-25 16:18:32 +03:00
Sait Talha Nisanci d09227d52e Add some normalization rules for pg14 2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 44f7e07530 Turn off COSTS to avoid alternative output for pg14 2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 65814b503e Change pg13 test to not differ with pg14 to avoid adding alternative output 2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 1171a4a3b6 Remove VERBOSE output to make pg14 and pg13 output the same 2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 84b1f74939 Use rte->updatedCols to determine if partition column exists
Use rte->updatedCols to determine if partition column exists in the
target list in case of UPDATE.

Commit on PG:
86dc90056dfdbd9d1b891718d2e5614e3e432f35
2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 9d73845580 Use oid_hash in write state management 2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 6391810632 Changes array_cat argument type from anyarray to anycompatiblearray
Relevant PG commit:
9e38c2bb5093ceb0c04d6315ccd8975bd17add66
2021-08-25 16:18:32 +03:00
Sait Talha Nisanci f287472150 Fix unlimited copy size variable's value 2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 1520b1900a Use empty string instead of NULL for queryString
Postgres doesn't accept NULL for queryStrings in explain plans anymore.
Internally, there are some places in Postgres where they modified the
NULLS to ""(the empty string). So we do the same on citus side.

Commit on Postgres:
1111b2668d89bfcb6f502789158b1233ab4217a6
2021-08-25 16:18:32 +03:00
Sait Talha Nisanci 8d6c5d1fb9 Use HASH_STRINGS explicitly in hash functions
Postgres expects to set the HASH_STRINGS explicitly in case of the
default behaivor for string hash function.

Postgres Commit
b3817f5f774663d55931dd4fab9c5a94a15ae7ab
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul c18ab06965 Renames shadowing ruleutils_14.c variables 2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 4dd455e7fe Introduces index_insert_compat macro
index_insert function now has a new parameter, indexUnchanged
This new macro give us the ability to use these new parameter for PG14 and they don't give the parameters for previous versions
Existing parameter is set to false

Relevant PG commit:
9dc718bdf2b1a574481a45624d42b674332e2903
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 9a1f793000 Introduces ExecSimpleRelationInsert_compat and modifyStateResultRelInfo macros
es_result_relation_info is removed from Estate. In this commit we make some changes to handle that.
resultRelationInfo filed is added to ModifyState to support the removed field.

Relevant PG commits:
1375422c7826a2bf387be29895e961614f69de4b
a04daa97a4339c38e304cd6164d37da540d665a8
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul ade73a733e Introduces GetOldestNonRemovableTransactionId_compat macro
GetOldestXmin function is removed so we use GetOldestNonRemovableTransactionId functions instead
GetOldestNonRemovableTransactionId_compat picks the appropriate one

Relevant PG commit:
dc7420c2c9274a283779ec19718d2d16323640c0
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 4b377c3fec Introduces get_partition_parent_compat and RelationGetPartitionDesc_compat macros
get_partition_parent and RelationGetPartitionDesc functions now have new parameters to also include detached partitions
Thess new macros give us the ability to use these new parameter for PG14 and they don't give the parameters for previous versions
Existing parameters are set to not accept detached partitions

Relevant PG commit:
71f4c8c6f74ba021e55d35b1128d22fb8c6e1629
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul d8f2796617 Introduces proc_statusflags_compat macro
In two commits vacuumFlags in PGXACT is moved and then renamed to status flags
This macro uses the appropriate version of the flag

Relevant PG commits:
5788e258bb26495fab65ff3aa486268d1c50b123
cd9c1b3e197a9b53b840dcc87eb41b04d601a5f9
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 4469fb2eee Introduces SetTuplestoreDestReceiverParams_compat macro
SetTuplestoreDestReceiverParams function now has two new parameters
This new macro give us the ability to use this new parameter for PG14 and it doesn't give the parameter for previous versions
Existing parameters are set to NULL to keep previous behavior

Relevant PG commit:
2f48ede080f42b97b594fb14102c82ca1001b80c
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 7c606837ab !!!!! DO NOT MERGE THIS COMMIT 2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 23c68e8ef3 Uses lfirst_node in ruleutils_14.c
Relevant PG commit:
2b00db4fb0c7f02f000276bfadaab65a14059168
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul ec3a4d2312 Adds missing include_out_argument parameter to func_get_detail in ruleutils_14.c
Relevant PG commit:
e56bce5d43789cce95d099554ae9593ada92b3b7
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 7ed9597684 Adds SQL-standard function body support to ruleutils_14.c
Relevant PG commit:
e717a9a18b2e34c9c40e5259ad4d31cd7e420750
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 9a9396ae21 Adds EXTRACT cases to get_func_sql_syntax in ruleutils_14.c
Relevant PG commit:
a2da77cdb4661826482ebf2ddba1f953bc74afe4
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 0476f52a0a Removes ModifyTable check from set_deparse_plan in ruleutils_14.c
Relevant PG commit:
86dc90056dfdbd9d1b891718d2e5614e3e432f35
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 7d8534537a Adds JOIN ... USING alias to ruleutils_14.c
Relevant PG commit:
055fee7eb4dcc78e58672aef146334275e1cc40d
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 2244738e0e Extends statistics on expressions in ruleutils_14.c
Relevant PG commit:
a4d75c86bf15220df22de0a92c819ecef9db3849
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 64c1e339f9 Adds GROUP BY DISTINCT to ruleutils_14.c
Relevant PG commit:
be45be9c33a85e72cdaeb9967e9f6d2d00199e09
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 9fdd06c2d6 Enhances cycle mark values at ruleutils_14.c
Relevant PG commit:
f4adc41c4f92cc91d507b19e397140c35bb9fd71
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 17f0afd883 Adds SEARCH and CYCLE clauses to ruleutils_14.c
Relevant PG commit:
3696a600e2292d43c00949ddf0352e4ebb487e5b
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul facab93ad2 Adds bytea equivalents of ltrim() and rtrim() to ruleutils_14.c
Relevant PG commit:
a6cf3df4ebdcbc7857910a67f259705645383e9f
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 4e38b0cbb8 Adds HASH_STRINGS flag to ruleutils_14.c
Relevant PG commit:
b3817f5f774663d55931dd4fab9c5a94a15ae7ab
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 8a994bb12c Removes dependency.h from ruleutils_14.c
Relevant PG commit:
8b069ef5dca97cd737a5fd64c420df3cd61ec1c9
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 2f02e775a5 Removes indexing.h header from ruleutils_14.c
Relevant PG commit:
bdc4edbea6fc847f806e1e7118d730e159512bfc
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 17b174be2a Adds SQL syntax function calls related changes to ruleutils_14.c
Relevant PG commit:
40c24bfef92530bd846e111c1742c2a54441c62c
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 483ff38118 Updates F_ARRAY_UNNEST to F_UNNEST_ANYARRAY in ruleutils_14.c
Relevant PG commit:
8e1f37c07aafd4bb7aa6e1e1982010af11f8b5c7
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 8733d4b5fa Fixes some appendStringInfos in ruleutils_14.c
Relevant PG commit:
110d81728a0a006abcf654543fc15346f8043dc0
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul d9109940e4 Adds for_each_from to ruleutils_14.c
Relevant PG commit:
56fe008996bc1a547ce60c8dddd2ca821cac163e
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 48149b369b Updates AlternativeSubPlan comment in ruleutils_14.c
Relevant PG commit:
41efb8340877e8ffd0023bb6b2ef22ffd1ca014d
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 59624c195a Removes support for postfix operators from ruleutils_14.c
Relevant PG commit:
1ed6b895634ce0dc5fd4bd040e87252b32182cba
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul be971a8cc9 Removes some comments with printf %.*s format from ruleutils_14.c
Relevant PG commit:

c410af098c46949e36607eb13689e697fa2def97
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul c33d805494 Fixes some indentation in ruleutils_14.c
Relevant PG commit:

fa27dd40d5c5f56a1ee837a75c97549e992e32a4
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul d7daea1533 Removes support for old protocols in Copy functions from PG14
Some Copy related functions copied from Postgres had support for both old and new protocols
Postgres removed support for old version so we remove it too

Relevant PG commit:
3174d69fb96a66173224e60ec7053b988d5ed4d9
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul cf1f1c3ab2 Introduces ProcessUtility macros for readOnlyTree parameter
New macros: standard_ProcessUtility_compat, ProcessUtility_compat, ColumnarProcessUtility_compat, PrevProcessUtilityHook_compat

The functions now have a new bool parameter: readOnlyTree
These new macros give us the ability to use this new parameter for PG14 and it doesn't give the parameter for previous versions

In multi_ProcessUtility and ColumnarProcessUtility, before doing anything else, we check if readOnlyTree parameter is true and create a copy of pstmt
Existing readOnlyTree parameters are set to false since we already handle the read only case at multi_ProcessUtility and ColumnarProcessUtility

Relevant PG commit:
7c337b6b527b7052e6a751f966d5734c56f668b5
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 2d421b95ef Removes CopyGetAttnums function definition for PG14
This function was copied from Postgres but it is not static at PG14
So we keep the definition only for previous versions

Relevant PG commit:
c532d15dddff14b01fe9ef1d465013cb8ef186df
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul c2f698674f Introduces BeginCopyFrom_compat macro
BeginCopyFrom function now has a new whereClause parameter.
In the function this parameter is assigned to the whereClause field of the CopyFromState returned
Currently in Postgres there is only one place where this argument isn't NULL, and in previous PG version the whereClause argument of copy state is set right after the function call
Since we don't have such example all current whereClause parameters are set to NULL

Relevant PG commit:
c532d15dddff14b01fe9ef1d465013cb8ef186df
2021-08-25 16:18:32 +03:00
Halil Ozan Akgul 4e2dd2274e Introduces CopyFromState_compat macro
CopyState struct is divided into parts and one of them is CopyFromState
This macro uses the appropriate one for PG versions

Relevant PG commit:
c532d15dddff14b01fe9ef1d465013cb8ef186df
2021-08-25 16:18:31 +03:00