external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,940 Commits
645 Branches
162 Tags
103 MiB
Commit Graph

3281 Commits (deee8e53dd3cd4ad864007f64d56fd6c41c92b61)

Author SHA1 Message Date
gindibay 37681eaed0 Fixes comment on code 2023-11-15 17:01:42 +03:00
gindibay 931514b0f7 Fixes indentation 2023-11-15 16:41:38 +03:00
gindibay 6f838e6e88 Fixes indentation 2023-11-15 16:34:02 +03:00
gindibay eb46d9399b Fixes warning on compile 2023-11-15 16:26:14 +03:00
gindibay 9a558bdece Adds datacl propagation 2023-11-15 16:04:26 +03:00
gindibay cf019b858c Adds static declarations 2023-11-14 10:21:23 +03:00
gindibay c1e9335fb7 Adds distributed check in metadata syncing 2023-11-14 09:01:00 +03:00
Gürkan İndibay 7780101619
Update src/backend/distributed/commands/database.c 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-13 19:00:40 +03:00
Gürkan İndibay 1e044a217d
Update src/backend/distributed/deparser/deparse_database_stmts.c 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-13 19:00:01 +03:00
Gürkan İndibay a956786bd8
Update src/backend/distributed/deparser/deparse_database_stmts.c 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-13 18:59:48 +03:00
Gürkan İndibay 32df3313d4
Update src/backend/distributed/metadata/metadata_sync.c 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-13 18:59:36 +03:00
Onur Tirtir c1dce6fc2b commit 2023-11-13 18:02:31 +03:00
Gürkan İndibay 7e15939e50
Update src/backend/distributed/commands/database.c 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-13 17:15:11 +03:00
gindibay fcdea98edd Removes drop in citus_internal_db_command udf 2023-11-13 15:58:09 +03:00
gindibay a9977e8840 Moves validation to preprocess for createdb 2023-11-13 15:49:19 +03:00
gindibay 712fd8ebf3 Fixes comments 2023-11-13 14:23:37 +03:00
gindibay 3731c45c29 Fixes drop force option 2023-11-13 14:19:19 +03:00
gindibay 52c9e92544 Adds IsAnyObjectDistributed check for db 2023-11-13 13:44:08 +03:00
Gürkan İndibay 8728871cc3
Apply suggestions from code review 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-13 14:56:24 +03:00
Onur Tirtir 1a80181a9c indent 2023-11-13 13:42:11 +03:00
Onur Tirtir 69217678b3 allow wal_log option only if it's set to default 2023-11-13 12:16:08 +03:00
Onur Tirtir f5a3f4d351 Merge remote-tracking branch 'origin/create_alter_database' into create_alter_database 2023-11-13 11:43:51 +03:00
Onur Tirtir 2ca6e2c358 indent 2023-11-13 11:43:31 +03:00
gindibay 974e628884 Merge branch 'create_alter_database' of https://github.com/citusdata/citus into create_alter_database 2023-11-13 11:42:00 +03:00
gindibay 30e1a858d2 Removes oid support 2023-11-13 11:41:58 +03:00
Onur Tirtir 5b446b1137 make tests passing 2023-11-13 11:27:29 +03:00
gindibay f8b3f322aa Fixed review items 2023-11-10 08:33:51 +03:00
Gürkan İndibay 3067d1ef08
Apply suggestions from code review 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-10 17:34:09 +03:00
gindibay 1b9a8ea2db Fixes indentation 2023-11-10 06:11:43 +03:00
gindibay 2ebeea3ce3 Fixes compilation warnings 2023-11-10 06:10:24 +03:00
gindibay 8df30a2a2b Fixes EnsureCitusInitiatedOperation name change 2023-11-10 05:52:14 +03:00
Gürkan İndibay 0a73cb31b0
Merge branch 'main' into create_alter_database 2023-11-10 14:12:48 +03:00
Onur Tirtir 240313e286
Support role commands from any node (#7278) 
DESCRIPTION: Adds support from issuing role management commands from worker nodes

It's unlikely to get into a distributed deadlock with role commands, we
don't care much about them at the moment.
There were several attempts to reduce the chances of a deadlock but we
didn't any of them merged into main branch yet, see:
#7325
#7016
#7009
 2023-11-10 09:58:51 +00:00
Nils Dijk 0dac63afc0
move pg_version_constants.h to toplevel include (#7335) 
In preparation of sorting and grouping all includes we wanted to move
this file to the toplevel includes for good grouping/sorting.
 2023-11-09 15:09:39 +00:00
gindibay 5f4092db5b Adds validation for template 2023-11-09 12:11:22 +03:00
Gürkan İndibay 32c67963bd
Merge branch 'main' into create_alter_database 2023-11-09 11:37:58 +03:00
gindibay 4c9863c0fb Fixes review comments 2023-11-09 01:49:43 +03:00
gindibay afa60556fd Fixes review comments 2023-11-09 01:43:08 +03:00
Gürkan İndibay 75589d1c11
Apply suggestions from code review 
Co-authored-by: Jelte Fennema-Nio <jelte.fennema@microsoft.com>
 2023-11-08 17:38:43 +03:00
gindibay 65660db10d Fixes review items 2023-11-08 02:02:00 +03:00
Onur Tirtir 444e6cb7d6
Remove useless variables (#7327) 
To fix warnings observed when using different compiler versions.
 2023-11-07 16:39:08 +03:00
cvbhjkl e535f53ce5
Fix typo in local_executor.c (#7324) 
Fix a typo 'remaning' -> 'remaining' in local_executor.c
 2023-11-03 12:14:11 +00:00
Cédric Villemain 0678a2fd89
Fix #7242, CALL(@0) crash backend (#7288) 
When executing a prepared CALL, which is not pure SQL but available with
some drivers like npgsql and jpgdbc, Citus entered a code path where a
plan is not defined, while trying to increase its cost. Thus SIG11 when
plan is a NULL pointer.

Fix by only increasing plan cost when plan is not null.

However, it is a bit suspicious to get here with a NULL plan and maybe a
better change will be to not call
ShardPlacementForFunctionColocatedWithDistTable() with a NULL plan at
all (in call.c:134)

bug hit with for example:
```
CallableStatement proc = con.prepareCall("{CALL p(?)}");
proc.registerOutParameter(1, java.sql.Types.BIGINT);
proc.setInt(1, -100);
proc.execute();
```

where `p(bigint)` is a distributed "function" and the param the
distribution key (also in a distributed table), see #7242 for details

Fixes #7242
 2023-11-02 13:15:24 +01:00
Gürkan İndibay 184c8fc1ee
Enriches statement propagation document (#7267) 
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
Co-authored-by: Jelte Fennema-Nio <jelte.fennema@microsoft.com>
 2023-11-02 09:59:34 +00:00
Jelte Fennema-Nio 0d83ab57de
Fix flaky multi_cluster_management (#7295) 
One of our most flaky and most anoying tests is
multi_cluster_management. It usually fails like this:
```diff
 SELECT citus_disable_node('localhost', :worker_2_port);
  citus_disable_node
 --------------------

 (1 row)

 SELECT public.wait_until_metadata_sync(60000);
+WARNING:  waiting for metadata sync timed out
  wait_until_metadata_sync
 --------------------------

 (1 row)

```

This tries to address that by hardening wait_until_metadata_sync. I
believe the reason for this warning is that there is a race condition in
wait_until_metadata_sync. It's possible for the pre-check to fail, then
have the maintenance daemon send a notification. And only then have the
backend start to listen. I tried to fix it in two ways:
1. First run LISTEN, and only then read do the pre-check.
2. If we time out, check again just to make sure that we did not miss
   the notification somehow. And don't show a warning if all metadata is
   synced after the timeout.

It's hard to know for sure that this fixes it because the test is not
repeatable and I could not reproduce it locally. Let's just hope for the
best.

---------

Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-01 10:46:01 +00:00
Gürkan İndibay 595d078f95
Merge branch 'main' into create_alter_database 2023-11-01 13:30:09 +03:00
Cédric Villemain 37415ef8f5
Allow citus_*_size on index related to a distributed table (#7271) 
I just enhanced the existing code to check if the relation is an index
belonging to a distributed table.
If so the shardId is appended to relation (index) name and the *_size
function are executed as before.

There is a change in an extern function:
  `extern StringInfo GenerateSizeQueryOnMultiplePlacements(...)`
It's possible to create a new function and deprecate this one later if
compatibility is an issue.

Fixes https://github.com/citusdata/citus/issues/6496.

DESCRIPTION: Allows using Citus size functions on distributed tables
indexes.

---------

Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
 2023-11-01 09:05:51 +00:00
Jelte Fennema-Nio c72f5357e1 Fix PG16 assertion 2023-10-31 16:10:03 +01:00
gindibay 2d9181a9ab Fixes indents 2023-10-31 11:00:40 +03:00
gindibay d8639d58de Adds locale restrictions 2023-10-31 10:58:44 +03:00