Marco Slot
90056f7d3c
Remove copy from worker for append-partitioned table
2020-01-13 23:03:40 -08:00
Philip Dubé
62524d152d
mitmscripts/fluent.py: use atomic increment
2020-01-13 20:35:08 +00:00
Philip Dubé
ccabf19090
Propagate DROP ROUTINE, ALTER ROUTINE
...
In two places I've made code more straight forward by using ROUTINE in our own codegen
Two changes which may seem extraneous:
AppendFunctionName was updated to not use pg_get_function_identity_arguments.
This is because that function includes ORDER BY when printing an aggregate like my_rank.
While ALTER AGGREGATE my_rank(x "any" ORDER BY y "any") is accepted by postgres,
ALTER ROUTINE my_rank(x "any" ORDER BY y "any") is not.
Tests were updated to use macaddr over integer. Using integer is flaky, our logic
could sometimes end up on tables like users_table. I originally wanted to use money,
but money isn't hashable.
2020-01-13 15:37:46 +00:00
Philip Dubé
4b5d6c3ebe
Rename RelayFileState to ShardState
...
Replace FILE_ prefix with SHARD_STATE_
2020-01-12 05:57:53 +00:00
Hadi Moshayedi
40ba2cdd6e
Test RedistributeTaskListResult
2020-01-09 23:47:25 -08:00
Philip Dubé
281aacce9b
Fix row-gather for subqueries being handled by task-tracker
...
task-tracker has specific logic for MultiPartition when GROUP BY is missing
We were ending up in this code path because row-gather removes GROUP BY
2020-01-10 01:51:37 +00:00
Hadi Moshayedi
bb65669186
Failure tests for PartitionTasklistResults
2020-01-09 10:55:58 -08:00
Hadi Moshayedi
f38d0e5b3f
Partitioned task list results.
2020-01-09 10:32:58 -08:00
Jelte Fennema
9724e25065
Normalize plan numbers in insert_select output
2020-01-07 10:34:08 +01:00
Philip Dubé
bf7d86a3e8
Fix typo: aggragate -> aggregate
2020-01-07 01:16:09 +00:00
Philip Dubé
863bf49507
Implement pulling up rows to coordinator when aggregates cannot be pushed down. Enabled by default
2020-01-07 01:16:04 +00:00
Onder Kalaci
7f3ab7892d
Skip shard pruning when possible
...
We're already traversing the queryTree and finding the distribution
key value, so pass it to the later stages of the planning.
2020-01-06 12:42:43 +01:00
Onder Kalaci
c8f14c9f6c
Make sure to update shard states of partitions on failures
...
Fixes #3331
In #2389 , we've implemented support for partitioned tables with rep > 1.
The implementation is limiting the use of modification queries on the
partitions. In fact, we error out when any partition is modified via
EnsurePartitionTableNotReplicated().
However, we seem to forgot an important case, where the parent table's
partition is marked as INVALID. In that case, at least one of the partition
becomes INVALID. However, we do not mark partitions as INVALID ever.
If the user queries the partition table directly, Citus could happily send
the query to INVALID placements -- which are not marked as INVALID.
This PR fixes it by marking the placements of the partitions as INVALID
as well.
The shard placement repair logic already re-creates all the partitions,
so should be fine in that front.
2020-01-06 12:26:08 +01:00
Jelte Fennema
3c770516eb
Commenting out flaky intermediate data leak test ( #3359 )
...
check-multi apparently has an intermediate data leak, so commenting out
that test for now. This was introduced by #3349
Examples:
- https://app.circleci.com/jobs/github/citusdata/citus/74675
- https://app.circleci.com/jobs/github/citusdata/citus/74683
- https://app.circleci.com/jobs/github/citusdata/citus/74763
2020-01-06 11:55:01 +01:00
Jelte Fennema
d29ce8965c
Actually check that test output normalization is applied in CI ( #3358 )
...
Fixup of an issue with #3336 that caused CI not to check correctly that
normalized test output was committed.
2020-01-06 10:37:34 +01:00
Jelte Fennema
4a20ba3bfc
Merge remote-tracking branch 'origin/master' into normalized-test-output
2020-01-06 09:36:04 +01:00
Jelte Fennema
2e4e1c030f
Make sure the expected .out file always exists when running diff on it
2020-01-06 09:32:03 +01:00
Jelte Fennema
16bcf15e16
Remove unused normalization rule
2020-01-06 09:32:03 +01:00
Jelte Fennema
634ea80009
Add a basic testing README including normalization explanation
2020-01-06 09:32:03 +01:00
Jelte Fennema
7c3e8e150e
Normalize tests: s/Subplan [0-9]+\_/Subplan XXX\_/g
2020-01-06 09:32:03 +01:00
Jelte Fennema
acd12a6de5
Normalize tests: s/read_intermediate_result\('[0-9]+_/read_intermediate_result('XXX_/g
2020-01-06 09:32:03 +01:00
Jelte Fennema
21dbd4e55d
Normalize tests: s/generating subplan [0-9]+\_/generating subplan XXX\_/g
2020-01-06 09:32:03 +01:00
Jelte Fennema
58723dd8b0
Normalize tests: s/DEBUG: Plan [0-9]+/DEBUG: Plan XXX/g
2020-01-06 09:32:03 +01:00
Jelte Fennema
34c5532e9c
Add commented out rules to normalize Plan numbers
2020-01-06 09:32:03 +01:00
Jelte Fennema
38ac28b4b8
Normalize tests: intermediate_results
2020-01-06 09:32:03 +01:00
Jelte Fennema
0c6983a80e
Normalize tests: pg12 changes
2020-01-06 09:32:03 +01:00
Jelte Fennema
7730bd449c
Normalize tests: Remove trailing whitespace
2020-01-06 09:32:03 +01:00
Jelte Fennema
6353c9907f
Normalize tests: Line info varies between versions
2020-01-06 09:32:03 +01:00
Jelte Fennema
bf2c203908
Normalize tests: solation_ref2ref_foreign_keys
2020-01-06 09:32:03 +01:00
Jelte Fennema
7b2c769a5d
Normalize tests: normalize file names for partitioned files
2020-01-06 09:32:03 +01:00
Jelte Fennema
98bab9caab
Normalize tests: ignore WAL warnings
2020-01-06 09:32:03 +01:00
Jelte Fennema
5c0f955ab9
Normalize tests: ignore could not consume warnings
2020-01-06 09:32:03 +01:00
Jelte Fennema
dc3cff991f
Normalize tests: normalize failed task ids
2020-01-06 09:32:03 +01:00
Jelte Fennema
d0ade90cd0
Normalize tests: pkey constraints for multi_insert_select
2020-01-06 09:32:03 +01:00
Jelte Fennema
704e1d2bc8
Normalize tests: shard table names for multi_name_lengths
2020-01-06 09:32:03 +01:00
Jelte Fennema
1c4ea6836b
Normalize tests: shard table names for multi_insert_select_conflict
2020-01-06 09:32:03 +01:00
Jelte Fennema
27997c054e
Normalize tests: shard table names for foreign_key_restrection_enforcement
2020-01-06 09:32:03 +01:00
Jelte Fennema
432b5baac7
Normalize tests: shard table names for custom_aggregate_support
2020-01-06 09:32:03 +01:00
Jelte Fennema
0c23caeb75
Normalize tests: shard table names for multi_subtransactions
2020-01-06 09:32:03 +01:00
Jelte Fennema
883ee9121f
Normalize tests: shard table names in foreign_key_to_reference_table
2020-01-06 09:32:03 +01:00
Jelte Fennema
7f3de68b0d
Normalize tests: header separator length
2020-01-06 09:32:03 +01:00
Philip Dubé
566246ecd4
End regression tests with ensure_no_intermediate_data_leak
...
Also update tests to clean up jobs when they're directly testing job udfs
2020-01-03 18:59:02 +00:00
Önder Kalacı
0c70a5470e
Allow RETURNING in fast-path queries ( #3352 )
...
* Allow RETURNING in fast-path queries
Because there is no specific reason for that.
2020-01-03 13:42:50 +00:00
Önder Kalacı
a174eb4f7b
Do not go through standard_planner() for INSERTs ( #3348 )
...
That seems unnecessary. We already have the notion of FastPath queries,
simply add it there.
2020-01-03 12:15:22 +00:00
Jelte Fennema
75a9c25acd
Normalize tests: s/node group [12] (but|does)/node group \1/
2020-01-03 11:46:01 +01:00
Jelte Fennema
96434e898f
Normalize tests: s/assigned task [0-9]+ to node/assigned task to node/
2020-01-03 11:45:22 +01:00
Jelte Fennema
7b833466ba
Normalize tests: s/shard [0-9]+/shard xxxxx/g
2020-01-03 11:44:30 +01:00
Jelte Fennema
8b5fe8aa17
Normalize tests: s/placement [0-9]+/placement xxxxx/g
2020-01-03 11:42:48 +01:00
Jelte Fennema
f21f00544e
Normalize tests: s/ port=[0-9]+ / port=xxxxx /g
2020-01-03 11:42:09 +01:00
Jelte Fennema
8c5c0dd74c
Normalize tests: s/localhost:[0-9]+/localhost:xxxxx/g
2020-01-03 11:40:50 +01:00