Add 5.2.0 CHANGELOG entry

Our longest yet!

.travis.yml

@@ -10,7 +10,7 @@ env:
   matrix:
     - PGVERSION=9.5
 before_install:
-  - git clone --depth 1 https://github.com/citusdata/tools.git
+  - git clone -b v0.3.3 --depth 1 https://github.com/citusdata/tools.git
   - tools/travis/setup_apt.sh
   - tools/travis/nuke_pg.sh
 install:

CHANGELOG.md

@@ -1,3 +1,69 @@
+### citus v5.2.0 (August 15, 2016) ###
+
+* Drops support for PostgreSQL 9.4; PostgreSQL 9.5 is required
+
+* Adds schema support for tables, other named objects (types, operators, etc.)
+
+* Evaluates non-immutable functions on master in all modification commands
+
+* Adds support for SERIAL types in non-partition columns
+
+* Adds support for RETURNING clause in INSERT, UPDATE, and DELETE commands
+
+* Adds support for multi-statement transactions involving a fixed set of nodes
+
+* Full SQL support for SELECT queries which can be executed on a single worker
+
+* Adds option to perform DDL changes using prepared transactions (2PC)
+
+* Adds an `enable_ddl_propagation` parameter to control DDL propagation
+
+* Accelerates shard pruning during merges
+
+* Adds `master_modify_multiple_shards` UDF to modify many shards at once
+
+* Adds COPY support for arrays of user-defined types
+
+* Now supports parameterized prepared statements for certain use cases
+
+* Extends LIMIT/OFFSET support to all executor types
+
+* Constraint violations now fail fast rather than hitting all placements
+
+* Makes `master_create_empty_shard` aware of shard placement policy
+
+* Reduces unnecessary sleep during queries processed by real-time executor
+
+* Improves task tracker executor's task cleanup logic
+
+* Relaxes restrictions on cancellation of DDL commands
+
+* Removes ONLY keyword from worker SELECT queries
+
+* Error message improvements and standardization
+
+* Moves `master_update_shard_statistics` function to `pg_catalog` schema
+
+* Fixes a bug where hash-partitioned anti-joins could return incorrect results
+
+* Now sets storage type correctly for foreign table-backed shards
+
+* Fixes `master_update_shard_statistics` issue with hash-partitioned tables
+
+* Fixes an issue related to extending table names that require escaping
+
+* Reduces risk of row counter overflows during modifications
+
+* Fixes a crash related to FILTER clause use in COUNT DISTINCT subqueries
+
+* Fixes crashes related to partition columns with high attribute numbers
+
+* Fixes certain subquery and join crashes
+
+* Detects flex for build even if PostgreSQL was built without it
+
+* Fixes assert-enabled crash when `all_modifications_commutative` is true
+
 ### citus v5.2.0-rc.1 (August 1, 2016) ###
 
 * Initial 5.2.0 candidate

src/backend/distributed/executor/multi_router_executor.c

@@ -294,7 +294,10 @@ AcquireExecutorShardLock(Task *task, LOCKMODE lockMode)
 {
 	int64 shardId = task->anchorShardId;
 
-	LockShardResource(shardId, lockMode);
+	if (shardId != INVALID_SHARD_ID)
+	{
+		LockShardResource(shardId, lockMode);
+	}
 }
 
 
@@ -818,7 +821,12 @@ ExtractParametersFromParamListInfo(ParamListInfo paramListInfo, Oid **parameterT
 			(*parameterTypes)[parameterIndex] = parameterData->ptype;
 		}
 
-		if (parameterData->isnull)
+		/*
+		 * If the parameter is NULL, or is not referenced / used (ptype == 0
+		 * would otherwise have errored out inside standard_planner()),
+		 * don't pass a value to the remote side.
+		 */
+		if (parameterData->isnull || parameterData->ptype == 0)
 		{
 			(*parameterValues)[parameterIndex] = NULL;
 			continue;

src/test/regress/expected/multi_fdw_master_protocol.out

@@ -25,10 +25,3 @@ SELECT * FROM master_get_new_shardid();
                  600000
 (1 row)
 
-SELECT node_name FROM master_get_local_first_candidate_nodes();
- node_name 
------------
- localhost
- localhost
-(2 rows)
-

src/test/regress/expected/multi_master_protocol.out

@@ -25,13 +25,6 @@ SELECT * FROM master_get_new_shardid();
                  740000
 (1 row)
 
-SELECT * FROM master_get_local_first_candidate_nodes();
- node_name | node_port 
------------+-----------
- localhost |     57638
- localhost |     57637
-(2 rows)
-
 SELECT * FROM master_get_round_robin_candidate_nodes(1);
  node_name | node_port 
 -----------+-----------

src/test/regress/expected/multi_router_planner.out

@@ -1530,6 +1530,11 @@ SELECT * FROM mv_articles_hash;
  41 |         1 | aznavour     |      11814
 (5 rows)
 
+DROP MATERIALIZED VIEW mv_articles_hash;
+DEBUG:  drop auto-cascades to type mv_articles_hash
+DEBUG:  drop auto-cascades to type mv_articles_hash[]
+DEBUG:  drop auto-cascades to rule _RETURN on materialized view mv_articles_hash
+DEBUG:  EventTriggerInvoke 16727
 CREATE MATERIALIZED VIEW mv_articles_hash_error AS
 	SELECT * FROM articles_hash WHERE author_id in (1,2);
 NOTICE:  cannot use shard pruning with ANY/ALL (array expression)
@@ -1537,13 +1542,6 @@ HINT:  Consider rewriting the expression with OR/AND clauses.
 NOTICE:  cannot use shard pruning with ANY/ALL (array expression)
 HINT:  Consider rewriting the expression with OR/AND clauses.
 ERROR:  cannot create temporary table within security-restricted operation
--- materialized views with (NO DATA) is still not supported
-CREATE MATERIALIZED VIEW mv_articles_hash AS
-	SELECT * FROM articles_hash WHERE author_id = 1 WITH NO DATA;
-DEBUG:  predicate pruning for shardId 840001
-DEBUG:  Creating router plan
-DEBUG:  Plan is router executable
-ERROR:  scan directions other than forward scans are unsupported
 	
 -- router planner/executor is disabled for task-tracker executor
 -- following query is router plannable, but router planner is disabled
@@ -1583,7 +1581,6 @@ DEBUG:  predicate pruning for shardId 840001
 SET client_min_messages to 'NOTICE';
 DROP FUNCTION author_articles_max_id();
 DROP FUNCTION author_articles_id_word_count();
-DROP MATERIALIZED VIEW mv_articles_hash;
 DROP TABLE articles_hash;
 DROP TABLE articles_single_shard_hash;
 DROP TABLE authors_hash;

src/test/regress/sql/multi_fdw_master_protocol.sql

@@ -15,5 +15,3 @@ SELECT part_storage_type, part_key, part_replica_count, part_max_size,
 SELECT * FROM master_get_table_ddl_events('lineitem');
 
 SELECT * FROM master_get_new_shardid();
-
-SELECT node_name FROM master_get_local_first_candidate_nodes();

src/test/regress/sql/multi_master_protocol.sql

@@ -15,8 +15,6 @@ SELECT * FROM master_get_table_ddl_events('lineitem');
 
 SELECT * FROM master_get_new_shardid();
 
-SELECT * FROM master_get_local_first_candidate_nodes();
-
 SELECT * FROM master_get_round_robin_candidate_nodes(1);
 
 SELECT * FROM master_get_round_robin_candidate_nodes(2);

src/test/regress/sql/multi_router_planner.sql

@@ -654,12 +654,10 @@ CREATE MATERIALIZED VIEW mv_articles_hash AS
 
 SELECT * FROM mv_articles_hash;
 
+DROP MATERIALIZED VIEW mv_articles_hash;
+
 CREATE MATERIALIZED VIEW mv_articles_hash_error AS
 	SELECT * FROM articles_hash WHERE author_id in (1,2);
-
--- materialized views with (NO DATA) is still not supported
-CREATE MATERIALIZED VIEW mv_articles_hash AS
-	SELECT * FROM articles_hash WHERE author_id = 1 WITH NO DATA;
 	
 -- router planner/executor is disabled for task-tracker executor
 -- following query is router plannable, but router planner is disabled
@@ -681,7 +679,6 @@ SET client_min_messages to 'NOTICE';
 DROP FUNCTION author_articles_max_id();
 DROP FUNCTION author_articles_id_word_count();
 
-DROP MATERIALIZED VIEW mv_articles_hash;
 DROP TABLE articles_hash;
 DROP TABLE articles_single_shard_hash;
 DROP TABLE authors_hash;