mirror of https://github.com/citusdata/citus.git
61d11ec2d4
There is a crash when running vanilla tests because of the `citus.hide_citus_dependent_objects` GUC. We turn on this GUC only for the pg vanilla tests. This GUC runs the following function `HideCitusDependentObjectsOnQueriesOfPgMetaTables`. This function doesn't take into account the new `mergeJoinCondition`. I rewrote the function such that it checks for merge join conditions as well. Relevant PG commit: https://github.com/postgres/postgres/commit/0294df2f1 The crash could be reproduced locally like the following: ```SQL SET citus.hide_citus_dependent_objects TO on; CREATE OR REPLACE FUNCTION pg_catalog.is_citus_depended_object(oid,oid) RETURNS bool LANGUAGE C AS 'citus', $$is_citus_depended_object$$; -- try a system catalog MERGE INTO pg_class c USING (SELECT 'pg_depend'::regclass AS oid) AS j ON j.oid = c.oid WHEN MATCHED THEN UPDATE SET reltuples = reltuples + 1 RETURNING j.oid; CREATE VIEW classv AS SELECT * FROM pg_class; MERGE INTO classv c USING pg_namespace n ON n.oid = c.relnamespace WHEN MATCHED AND c.oid = 'pg_depend'::regclass THEN UPDATE SET reltuples = reltuples - 1 RETURNING c.oid; -- crash happens here ``` |
||
|---|---|---|
| .. | ||
| acquire_lock.c | ||
| aggregate_utils.c | ||
| array_type.c | ||
| background_jobs.c | ||
| cancel_utils.c | ||
| citus_clauses.c | ||
| citus_copyfuncs.c | ||
| citus_depended_object.c | ||
| citus_nodefuncs.c | ||
| citus_outfuncs.c | ||
| citus_readfuncs.c | ||
| citus_safe_lib.c | ||
| citus_stat_tenants.c | ||
| citus_version.c | ||
| colocation_utils.c | ||
| directory.c | ||
| distribution_column.c | ||
| distribution_column_map.c | ||
| enable_ssl.c | ||
| errormessage.c | ||
| foreign_key_relationship.c | ||
| function.c | ||
| function_utils.c | ||
| hash_helpers.c | ||
| jsonbutils.c | ||
| listutils.c | ||
| log_utils.c | ||
| maintenanced.c | ||
| multi_partitioning_utils.c | ||
| namespace_utils.c | ||
| param_utils.c | ||
| priority.c | ||
| query_utils.c | ||
| reference_table_utils.c | ||
| relation_utils.c | ||
| replication_origin_session_utils.c | ||
| resource_lock.c | ||
| role.c | ||
| shard_utils.c | ||
| shardinterval_utils.c | ||
| statistics_collection.c | ||
| string_utils.c | ||
| task_execution_utils.c | ||
| tenant_schema_metadata.c | ||
| tuplestore.c | ||
| type_utils.c | ||