Colm bd0558fe39 Remove incorrect assertion from Postgres ruleutils. (#8136) ... DESCRIPTION: Remove an assertion from Postgres ruleutils that was rendered meaningless by a previous Citus commit. Fixes #8123. This has been present since 00068e0, which changed the code preceding the assert as follows: ``` #ifdef USE_ASSERT_CHECKING - while (i < colinfo->num_cols && colinfo->colnames[i] == NULL) - i++; + for (int col_index = 0; col_index < colinfo->num_cols; col_index++) + { + /* + * In the above processing-loops, "i" advances only if + * the column is not new, check if this is a new column. + */ + if (colinfo->is_new_col[col_index]) + i++; + } Assert(i == colinfo->num_cols); Assert(j == nnewcolumns); #endif ``` This commit altered both the loop condition and the incrementing of `i`. After analysis, the assert no longer makes sense.		2025-08-19 15:52:13 +01:00
..
backend	Remove incorrect assertion from Postgres ruleutils. (#8136)	2025-08-19 15:52:13 +01:00
include	Snapshot-Based Node Split – Foundation and Core Implementation (#8122)	2025-08-19 14:13:55 +03:00
test	Snapshot-Based Node Split – Foundation and Core Implementation (#8122)	2025-08-19 14:13:55 +03:00