external
/
pg_stat_monitor
mirror of https://github.com/percona/pg_stat_monitor.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PG-369: Fix wal_bytes values on PG <= 12. 

Similar to pg_stat_statements, pg_stat_monitor tracks wal data metrics
since PostgreSQL 13, the problem was that for PostgreSQL versions 11 and
12 we left the WalUsage variable declared in the stack unitialized,
thus leading to garbage values.

Fixed the problem by ignoring the WalUsage variable value for PG <= 12.
pull/201/head
Diego Fronza 2022-04-11 14:20:43 -03:00
parent 1ed35c648a
commit 409f384ce8
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pg_stat_monitor.c
View File

@ -989,9 +989,9 @@ static void pgss_ProcessUtility(PlannedStmt *pstmt, const char *queryString,
instr_time duration; instr_time duration;
uint64 rows; uint64 rows;
BufferUsage bufusage; BufferUsage bufusage;
WalUsage walusage;
BufferUsage bufusage_start = pgBufferUsage; BufferUsage bufusage_start = pgBufferUsage;
#if PG_VERSION_NUM >= 130000 #if PG_VERSION_NUM >= 130000
WalUsage walusage;
WalUsage walusage_start = pgWalUsage; WalUsage walusage_start = pgWalUsage;
#endif #endif
INSTR_TIME_SET_CURRENT(start); INSTR_TIME_SET_CURRENT(start);
@ -1083,7 +1083,11 @@ static void pgss_ProcessUtility(PlannedStmt *pstmt, const char *queryString,
INSTR_TIME_GET_MILLISEC(duration), /* total_time */ INSTR_TIME_GET_MILLISEC(duration), /* total_time */
rows, /* rows */ rows, /* rows */
&bufusage, /* bufusage */ &bufusage, /* bufusage */
#if PG_VERSION_NUM >= 130000
&walusage, /* walusage */ &walusage, /* walusage */
#else
NULL, /* walusage, NULL for PG <= 12 */
#endif
NULL, /* JumbleState */ NULL, /* JumbleState */
PGSS_FINISHED); /* pgssStoreKind */ PGSS_FINISHED); /* pgssStoreKind */
} }