external
/
pg_stat_monitor
mirror of https://github.com/percona/pg_stat_monitor.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PG-286: Check for NULL return on hash_search before using object. 

Check if hash_search() function returns NULL before attempting to
use the object in hash_entry_alloc().
pull/157/head
Diego Fronza 2021-12-04 11:01:39 -03:00
parent 59c321ebc5
commit a071516a0f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hash_query.c
View File

@ -149,7 +149,9 @@ hash_entry_alloc(pgssSharedState *pgss, pgssHashKey *key, int encoding)
} }
/* Find or create an entry with desired hash code */ /* Find or create an entry with desired hash code */
entry = (pgssEntry *) hash_search(pgss_hash, key, HASH_ENTER_NULL, &found); entry = (pgssEntry *) hash_search(pgss_hash, key, HASH_ENTER_NULL, &found);
if (!found) if (entry == NULL)
pgsm_log_error("hash_entry_alloc: OUT OF MEMORY");
else if (!found)
{ {
pgss->bucket_entry[pg_atomic_read_u64(&pgss->current_wbucket)]++; pgss->bucket_entry[pg_atomic_read_u64(&pgss->current_wbucket)]++;
/* New entry, initialize it */ /* New entry, initialize it */
@ -161,8 +163,6 @@ hash_entry_alloc(pgssSharedState *pgss, pgssHashKey *key, int encoding)
/* ... and don't forget the query text metadata */ /* ... and don't forget the query text metadata */
entry->encoding = encoding; entry->encoding = encoding;
} }
if (entry == NULL)
pgsm_log_error("hash_entry_alloc: OUT OF MEMORY");
return entry; return entry;
} }