From c8d72091492e2eb37588b86f6e2005c5486ee92f Mon Sep 17 00:00:00 2001 From: Ibrar Ahmed Date: Tue, 16 Nov 2021 11:38:21 +0000 Subject: [PATCH] PG-273: pg_stat_monitor_hook_stats disable to end user. --- pg_stat_monitor--1.0.13.sql.in | 38 +++++++++++++++---------------- pg_stat_monitor--1.0.14.sql.in | 40 ++++++++++++++++----------------- pg_stat_monitor--1.0.sql.in | 41 ++++++++++++++++++---------------- 3 files changed, 61 insertions(+), 58 deletions(-) diff --git a/pg_stat_monitor--1.0.13.sql.in b/pg_stat_monitor--1.0.13.sql.in index e9e855e..990e62b 100644 --- a/pg_stat_monitor--1.0.13.sql.in +++ b/pg_stat_monitor--1.0.13.sql.in @@ -236,26 +236,26 @@ end loop; END $$ language plpgsql; -CREATE FUNCTION pg_stat_monitor_hook_stats( - OUT hook text, - OUT min_time float8, - OUT max_time float8, - OUT total_time float8, - OUT ncalls int8 -) -RETURNS SETOF record -AS 'MODULE_PATHNAME', 'pg_stat_monitor_hook_stats' -LANGUAGE C STRICT VOLATILE PARALLEL SAFE; +--CREATE FUNCTION pg_stat_monitor_hook_stats( +-- OUT hook text, +-- OUT min_time float8, +-- OUT max_time float8, +-- OUT total_time float8, +-- OUT ncalls int8 +--) +--RETURNS SETOF record +--AS 'MODULE_PATHNAME', 'pg_stat_monitor_hook_stats' +--LANGUAGE C STRICT VOLATILE PARALLEL SAFE; -CREATE VIEW pg_stat_monitor_hook_stats AS SELECT - hook, - min_time, - max_time, - total_time, - total_time / greatest(ncalls, 1) as avg_time, - ncalls, - ROUND(CAST(total_time / greatest(sum(total_time) OVER(), 0.00000001) * 100 as numeric), 2)::text || '%' as load_comparison -FROM pg_stat_monitor_hook_stats(); +--CREATE VIEW pg_stat_monitor_hook_stats AS SELECT +-- hook, +-- min_time, +-- max_time, +-- total_time, +-- total_time / greatest(ncalls, 1) as avg_time, +-- ncalls, +-- ROUND(CAST(total_time / greatest(sum(total_time) OVER(), 0.00000001) * 100 as numeric), 2)::text || '%' as load_comparison +--FROM pg_stat_monitor_hook_stats(); GRANT SELECT ON pg_stat_monitor TO PUBLIC; GRANT SELECT ON pg_stat_monitor_settings TO PUBLIC; diff --git a/pg_stat_monitor--1.0.14.sql.in b/pg_stat_monitor--1.0.14.sql.in index 76ec2d5..dae64b8 100644 --- a/pg_stat_monitor--1.0.14.sql.in +++ b/pg_stat_monitor--1.0.14.sql.in @@ -237,26 +237,26 @@ end loop; END $$ language plpgsql; -CREATE FUNCTION pg_stat_monitor_hook_stats( - OUT hook text, - OUT min_time float8, - OUT max_time float8, - OUT total_time float8, - OUT ncalls int8 -) -RETURNS SETOF record -AS 'MODULE_PATHNAME', 'pg_stat_monitor_hook_stats' -LANGUAGE C STRICT VOLATILE PARALLEL SAFE; - -CREATE VIEW pg_stat_monitor_hook_stats AS SELECT - hook, - min_time, - max_time, - total_time, - total_time / greatest(ncalls, 1) as avg_time, - ncalls, - ROUND(CAST(total_time / greatest(sum(total_time) OVER(), 0.00000001) * 100 as numeric), 2)::text || '%' as load_comparison -FROM pg_stat_monitor_hook_stats(); +--CREATE FUNCTION pg_stat_monitor_hook_stats( +-- OUT hook text, +-- OUT min_time float8, +-- OUT max_time float8, +-- OUT total_time float8, +-- OUT ncalls int8 +--) +--RETURNS SETOF record +--AS 'MODULE_PATHNAME', 'pg_stat_monitor_hook_stats' +--LANGUAGE C STRICT VOLATILE PARALLEL SAFE; +-- +--CREATE VIEW pg_stat_monitor_hook_stats AS SELECT +-- hook, +-- min_time, +-- max_time, +-- total_time, +-- total_time / greatest(ncalls, 1) as avg_time, +-- ncalls, +-- ROUND(CAST(total_time / greatest(sum(total_time) OVER(), 0.00000001) * 100 as numeric), 2)::text || '%' as load_comparison +--FROM pg_stat_monitor_hook_stats(); GRANT SELECT ON pg_stat_monitor TO PUBLIC; GRANT SELECT ON pg_stat_monitor_settings TO PUBLIC; diff --git a/pg_stat_monitor--1.0.sql.in b/pg_stat_monitor--1.0.sql.in index 544f668..fd2495d 100644 --- a/pg_stat_monitor--1.0.sql.in +++ b/pg_stat_monitor--1.0.sql.in @@ -223,28 +223,31 @@ end loop; END $$ language plpgsql; -CREATE FUNCTION pg_stat_monitor_hook_stats( - OUT hook text, - OUT min_time float8, - OUT max_time float8, - OUT total_time float8, - OUT ncalls int8 -) -RETURNS SETOF record -AS 'MODULE_PATHNAME', 'pg_stat_monitor_hook_stats' -LANGUAGE C STRICT VOLATILE PARALLEL SAFE; +-- CREATE FUNCTION pg_stat_monitor_hook_stats( +-- OUT hook text, +-- OUT min_time float8, +-- OUT max_time float8, +-- OUT total_time float8, +-- OUT ncalls int8 +--) +--RETURNS SETOF record +--AS 'MODULE_PATHNAME', 'pg_stat_monitor_hook_stats' +--LANGUAGE C STRICT VOLATILE PARALLEL SAFE; -CREATE VIEW pg_stat_monitor_hook_stats AS SELECT - hook, - min_time, - max_time, - total_time, - total_time / greatest(ncalls, 1) as avg_time, - ncalls, - ROUND(CAST(total_time / greatest(sum(total_time) OVER(), 0.00000001) * 100 as numeric), 2)::text || '%' as load_comparison -FROM pg_stat_monitor_hook_stats(); +--CREATE VIEW pg_stat_monitor_hook_stats AS SELECT +-- hook, +-- min_time, +-- max_time, +-- total_time, +-- total_time / greatest(ncalls, 1) as avg_time, +-- ncalls, +-- ROUND(CAST(total_time / greatest(sum(total_time) OVER(), 0.00000001) * 100 as numeric), 2)::text || '%' as load_comparison +-- FROM pg_stat_monitor_hook_stats(); GRANT SELECT ON pg_stat_monitor TO PUBLIC; GRANT SELECT ON pg_stat_monitor_settings TO PUBLIC; + -- Don't want this to be available to non-superusers. REVOKE ALL ON FUNCTION pg_stat_monitor_reset() FROM PUBLIC; + +