external/pg_stat_monitor
1
0
Fork 0
mirror of https://github.com/percona/pg_stat_monitor.git synced 2026-02-04 05:56:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

PG-607: Allow histogram to track queries in sub-ms time brackets (#384)

Browse Source 
* PG-607: Allow histogram to track queries in sub-ms time brackets

Updated the GUC configuration and the relevant histogram functionality
to track queries in lower cardinality than ms. This is done by saving
the GUC values for histogram min and max values in real (double) type.

All test cases except for the 030 tap test are passing. The test case
needs an update.

* Fixing regression issues for v12 and below because of histogram changes.
This commit is contained in:
Muhammad Usama
2023-02-23 21:24:40 +05:00
committed by GitHub
parent 05ffcac2fa
commit fe23d31bf9
10 changed files with 74 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
pg_stat_monitor.c
View File

@@ -82,9 +82,9 @@ static int plan_nested_level = 0;
/* Histogram bucket variables */
static double hist_bucket_min;
static double hist_bucket_max;
static double hist_bucket_timings[MAX_RESPONSE_BUCKET + 2][2]; /* Start and end timings */
static int hist_bucket_count_user;
static int hist_bucket_count_total;
int64 hist_bucket_timings[MAX_RESPONSE_BUCKET + 2][2]; /* Start and end timings */
static uint32 pgsm_client_ip = PGSM_INVALID_IP_MASK;
@@ -112,7 +112,7 @@ static char *pgsm_explain(QueryDesc *queryDesc);
static void extract_query_comments(const char *query, char *comments, size_t max_len);
static void set_histogram_bucket_timings(void);
static void histogram_bucket_timings(int index, int64 *b_start, int64 *b_end);
static void histogram_bucket_timings(int index, double *b_start, double *b_end);
static int get_histogram_bucket(double q_time);
static bool IsSystemInitialized(void);
@@ -3545,8 +3545,8 @@ unpack_sql_state(int sql_state)
static void
set_histogram_bucket_timings(void)
{
int64 b2_start;
int64 b2_end;
double b2_start;
double b2_end;
int b_count;
hist_bucket_min = pgsm_histogram_min;
@@ -3596,7 +3596,7 @@ set_histogram_bucket_timings(void)
* Given an index, return the histogram start and end times.
*/
static void
histogram_bucket_timings(int index, int64 *b_start, int64 *b_end)
histogram_bucket_timings(int index, double *b_start, double *b_end)
{
double q_min = hist_bucket_min;
double q_max = hist_bucket_max;
@@ -3640,7 +3640,7 @@ static int
get_histogram_bucket(double q_time)
{
int index = 0;
int64 exec_time = (int64)q_time;
double exec_time = q_time;
for (index = 0; index < hist_bucket_count_total; index++)
{
@@ -3662,8 +3662,8 @@ get_histogram_bucket(double q_time)
Datum
get_histogram_timings(PG_FUNCTION_ARGS)
{
int64 b_start;
int64 b_end;
double b_start;
double b_end;
int b_count = hist_bucket_count_total;
int index = 0;
char *tmp_str = palloc0(MAX_STRING_LEN);
@@ -3675,16 +3675,16 @@ get_histogram_timings(PG_FUNCTION_ARGS)
if (index == 0)
{
snprintf(text_str, MAX_STRING_LEN, "{{%ld - %ld}", b_start, b_end);
snprintf(text_str, MAX_STRING_LEN, "{{%.3lf - %.3lf}", b_start, b_end);
}
else if (index == (b_count - 1))
{
snprintf(tmp_str, MAX_STRING_LEN, "%s, (%ld - ...}}", text_str, b_start);
snprintf(tmp_str, MAX_STRING_LEN, "%s, (%.3lf - ...}}", text_str, b_start);
snprintf(text_str, MAX_STRING_LEN, "%s", tmp_str);
}
else
{
snprintf(tmp_str, MAX_STRING_LEN, "%s, (%ld - %ld}", text_str, b_start, b_end);
snprintf(tmp_str, MAX_STRING_LEN, "%s, (%.3lf - %.3lf}", text_str, b_start, b_end);
snprintf(text_str, MAX_STRING_LEN, "%s", tmp_str);
}
}