mirror of
https://github.com/percona/pg_stat_monitor.git
synced 2026-02-04 05:56:21 +00:00
130d6b5fce
* PG-592: Treat queries with different parent queries as separate entries 1. Previously pg_stat_monitor had a `topquery` and `topqueryid` field, but it was only a sample: it showed one of the top queries executing the specific query. With this change, the same entry executed by two different functions will result in two entries in the statistics table. 2. This also fixes a bug where the content of these field disappeared for every second query executed: previously the update function changed topqueryid to `0` if it was non zero, and changed it to the proper id when it was 0. This resulted in an alternating behavior, where for every second executed query the top query disappeared. After these changes, the top query is always shown. 3. The previous implementation also leaked dsa memory used to store the parent queries. This is now also fixed. * PG-502: Fixing review comments * dsa_free changed to assert as it can never happen * restructured the ifs to be cleaner Note: kept the two-level ifs, as that makes more sense with the assert Note: didn't convert nested_level checks to macro, as it is used differently at different parts of the code * PG-502: Fixing review comments * PG-592 Add regression test * Make test compatible with PG12 * Remove redundant line --------- Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
33 lines
1.2 KiB
Makefile
33 lines
1.2 KiB
Makefile
# contrib/pg_stat_monitor/Makefile
|
|
|
|
MODULE_big = pg_stat_monitor
|
|
OBJS = hash_query.o guc.o pg_stat_monitor.o $(WIN32RES)
|
|
|
|
EXTENSION = pg_stat_monitor
|
|
DATA = pg_stat_monitor--2.0.sql pg_stat_monitor--1.0--2.0.sql pg_stat_monitor--2.0--2.1.sql
|
|
|
|
PGFILEDESC = "pg_stat_monitor - execution statistics of SQL statements"
|
|
|
|
LDFLAGS_SL += $(filter -lm, $(LIBS))
|
|
|
|
TAP_TESTS = 1
|
|
REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/pg_stat_monitor/pg_stat_monitor.conf --inputdir=regression
|
|
REGRESS = basic version guc pgsm_query_id functions counters relations database error_insert application_name application_name_unique top_query different_parent_queries cmd_type error rows tags user level_tracking
|
|
|
|
# Disabled because these tests require "shared_preload_libraries=pg_stat_statements",
|
|
# which typical installcheck users do not have (e.g. buildfarm clients).
|
|
# NO_INSTALLCHECK = 1
|
|
|
|
PG_CONFIG ?= pg_config
|
|
|
|
ifdef USE_PGXS
|
|
MAJORVERSION := $(shell $(PG_CONFIG) --version | awk {'print $$2'} | cut -f1 -d".")
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
include $(PGXS)
|
|
else
|
|
subdir = contrib/pg_stat_monitor
|
|
top_builddir = ../..
|
|
include $(top_builddir)/src/Makefile.global
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
endif
|