b920224e0f
* PG-475: Inconsistent behaviour of PGSM Reverting the bucket locking mechanism to previous behavior. This has a lot of room for improvement that needs to be part of a major refactoring in the 2.x release. * PG-481 Release notes 1.1.0 (#294) modified: RELEASE_NOTES.md * PG-500: Bump the version of pg_stat_monitor to 1.1.0 (#297) * PG-501: Missing Buckets and incorrect calls count. (#298) prev_bucket_sec holds the actual time at which the previous bucket was created and it is used to compute if the previous bucket time has elapsed and when is the time to create a new one. But since the bucket start time is rounded down to logical time window start, that makes the prev_bucket_sec and bucket start time out of sync with each other, and depending on the query arrival time there is a high probability that a bucket gets missed especially when the last bucket was created around the end of the bucket time window. Solution is to keep the prev_bucket_sec and bucket start time in-sync. Moreover, we are using the unint64 for storing the prev_bucket_sec which is kind of an overkill and a simple uint should be good enough for the purpose. But that change can be taken up as part of the create-bucket function refactoring task. * PG-501: Missing Buckets and incorrect calls count. Ensuring the outer bound for the bucket is an exclusive boundary and it as it belongs to the next bucket. To explain the point further, a set of five second bucket would be: Bucket 1: 00:00:00.00 -> 00:00:04.99... Bucket 2: 00:00:00.05 -> 00:00:09.99... Bucket 3: 00:00:00.10 -> 00:00:14.99... ... Co-authored-by: Ibrar Ahmed <ibrar.ahmed@percona.com> Co-authored-by: Anastasia Alexandrova <anastasia.alexandrova@percona.com> Co-authored-by: Muhammad Usama <m.usama@gmail.com> |
||
|---|---|---|
| .. | ||
| expected | ||
| sql | ||