external
/
postgres-decoderbufs
mirror of https://github.com/debezium/postgres-decoderbufs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added explicit null value information 

When updating a row with a large text column, but the large column's value is unchanged, decoderbufs won't send the value of the column to the logical subscriber. However, the subscriber has no way to detect whether the column was left untouched or deliberately given a null value. Adding explicit null value information on each datum should rectify this situation.
pull/19/head
James 2019-06-26 22:06:00 +07:00
parent 0b536f372e
commit 179a7eed38
4 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
proto/pg_logicaldec.proto
View File

@ -28,6 +28,7 @@ message DatumMessage {
bytes datum_bytes = 9; bytes datum_bytes = 9;
Point datum_point = 10; Point datum_point = 10;
} }
optional bool column_null = 11;
} }
message TypeInfo { message TypeInfo {

1
src/decoderbufs.c
View File

@ -456,6 +456,7 @@ static void tuple_to_tuple_msg(Decoderbufs__DatumMessage **tmsg,
} }
} else { } else {
elog(DEBUG1, "column %s is null, ignoring value", attrName); elog(DEBUG1, "column %s is null, ignoring value", attrName);
datum_msg.has_column_null = datum_msg.column_null = true;
} }
tmsg[valid_attr_cnt] = palloc(sizeof(datum_msg)); tmsg[valid_attr_cnt] = palloc(sizeof(datum_msg));

19
src/proto/pg_logicaldec.pb-c.c
View File

@ -230,7 +230,7 @@ const ProtobufCMessageDescriptor decoderbufs__point__descriptor =
(ProtobufCMessageInit) decoderbufs__point__init, (ProtobufCMessageInit) decoderbufs__point__init,
NULL,NULL,NULL /* reserved[123] */ NULL,NULL,NULL /* reserved[123] */
}; };
static const ProtobufCFieldDescriptor decoderbufs__datum_message__field_descriptors[10] = static const ProtobufCFieldDescriptor decoderbufs__datum_message__field_descriptors[11] =
{ {
{ {
"column_name", "column_name",
@ -352,9 +352,22 @@ static const ProtobufCFieldDescriptor decoderbufs__datum_message__field_descript
0 | PROTOBUF_C_FIELD_FLAG_ONEOF, /* flags */ 0 | PROTOBUF_C_FIELD_FLAG_ONEOF, /* flags */
0,NULL,NULL /* reserved1,reserved2, etc */ 0,NULL,NULL /* reserved1,reserved2, etc */
}, },
{
"column_null",
11,
PROTOBUF_C_LABEL_OPTIONAL,
PROTOBUF_C_TYPE_BOOL,
offsetof(Decoderbufs__DatumMessage, has_column_null),
offsetof(Decoderbufs__DatumMessage, column_null),
NULL,
NULL,
0, /* flags */
0,NULL,NULL /* reserved1,reserved2, etc */
},
}; };
static const unsigned decoderbufs__datum_message__field_indices_by_name[] = { static const unsigned decoderbufs__datum_message__field_indices_by_name[] = {
0, /* field[0] = column_name */ 0, /* field[0] = column_name */
10, /* field[10] = column_null */
1, /* field[1] = column_type */ 1, /* field[1] = column_type */
6, /* field[6] = datum_bool */ 6, /* field[6] = datum_bool */
8, /* field[8] = datum_bytes */ 8, /* field[8] = datum_bytes */
@ -368,7 +381,7 @@ static const unsigned decoderbufs__datum_message__field_indices_by_name[] = {
static const ProtobufCIntRange decoderbufs__datum_message__number_ranges[1 + 1] = static const ProtobufCIntRange decoderbufs__datum_message__number_ranges[1 + 1] =
{ {
{ 1, 0 }, { 1, 0 },
{ 0, 10 } { 0, 11 }
}; };
const ProtobufCMessageDescriptor decoderbufs__datum_message__descriptor = const ProtobufCMessageDescriptor decoderbufs__datum_message__descriptor =
{ {
@ -378,7 +391,7 @@ const ProtobufCMessageDescriptor decoderbufs__datum_message__descriptor =
"Decoderbufs__DatumMessage", "Decoderbufs__DatumMessage",
"decoderbufs", "decoderbufs",
sizeof(Decoderbufs__DatumMessage), sizeof(Decoderbufs__DatumMessage),
10, 11,
decoderbufs__datum_message__field_descriptors, decoderbufs__datum_message__field_descriptors,
decoderbufs__datum_message__field_indices_by_name, decoderbufs__datum_message__field_indices_by_name,
1, decoderbufs__datum_message__number_ranges, 1, decoderbufs__datum_message__number_ranges,

4
src/proto/pg_logicaldec.pb-c.h
View File

@ -61,6 +61,8 @@ struct _Decoderbufs__DatumMessage
char *column_name; char *column_name;
protobuf_c_boolean has_column_type; protobuf_c_boolean has_column_type;
int64_t column_type; int64_t column_type;
protobuf_c_boolean has_column_null;
protobuf_c_boolean column_null;
Decoderbufs__DatumMessage__DatumCase datum_case; Decoderbufs__DatumMessage__DatumCase datum_case;
union { union {
int32_t datum_int32; int32_t datum_int32;
@ -75,7 +77,7 @@ struct _Decoderbufs__DatumMessage
}; };
#define DECODERBUFS__DATUM_MESSAGE__INIT \ #define DECODERBUFS__DATUM_MESSAGE__INIT \
{ PROTOBUF_C_MESSAGE_INIT (&decoderbufs__datum_message__descriptor) \ { PROTOBUF_C_MESSAGE_INIT (&decoderbufs__datum_message__descriptor) \
, NULL, 0,0, DECODERBUFS__DATUM_MESSAGE__DATUM__NOT_SET, {0} } , NULL, 0,0, 0,0, DECODERBUFS__DATUM_MESSAGE__DATUM__NOT_SET, {0} }
struct _Decoderbufs__TypeInfo struct _Decoderbufs__TypeInfo