shancheas
f2f0be111a
- Added .cursor/sessions/* to .gitignore to prevent session files from being tracked. - Enhanced coding standards in SKILL.md by adding semicolons to TypeScript examples for consistency. - Improved formatting in continuous learning, detail layout, and other SKILL.md files for better readability. These changes aim to streamline development processes and maintain code quality across the project.
45 lines
987 B
Markdown
45 lines
987 B
Markdown
# Code Review
|
|
|
|
Comprehensive security and quality review of uncommitted changes:
|
|
|
|
1. Get changed files: git diff --name-only HEAD
|
|
|
|
2. For each changed file, check for:
|
|
|
|
**Security Issues (CRITICAL):**
|
|
|
|
- Hardcoded credentials, API keys, tokens
|
|
- SQL injection vulnerabilities
|
|
- XSS vulnerabilities
|
|
- Missing input validation
|
|
- Insecure dependencies
|
|
- Path traversal risks
|
|
|
|
**Code Quality (HIGH):**
|
|
|
|
- Functions > 50 lines
|
|
- Files > 800 lines
|
|
- Nesting depth > 4 levels
|
|
- Missing error handling
|
|
- console.log statements
|
|
- TODO/FIXME comments
|
|
- Missing JSDoc for public APIs
|
|
|
|
**Best Practices (MEDIUM):**
|
|
|
|
- Mutation patterns (use immutable instead)
|
|
- Emoji usage in code/comments
|
|
- Missing tests for new code
|
|
- Accessibility issues (a11y)
|
|
|
|
3. Generate report with:
|
|
|
|
- Severity: CRITICAL, HIGH, MEDIUM, LOW
|
|
- File location and line numbers
|
|
- Issue description
|
|
- Suggested fix
|
|
|
|
4. Block commit if CRITICAL or HIGH issues found
|
|
|
|
Never approve code with security vulnerabilities!
|