external
/
citus
mirror of https://github.com/citusdata/citus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Introduce helper functions for getting lockmode

pull/7009/head
Hanefi Onaldi 2023-06-21 01:07:39 +03:00
parent dde8e26e90
commit 01ce923aea
No known key found for this signature in database
GPG Key ID: F18CDB10BA0DFDC7
2 changed files with 37 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/backend/distributed/commands/index.c
View File

@ -553,11 +553,9 @@ ReindexStmtFindRelationOid(ReindexStmt *reindexStmt, bool missingOk)
Oid relationId = InvalidOid; Oid relationId = InvalidOid;
LOCKMODE lockmode = IsReindexWithParam_compat(reindexStmt, "concurrently") ?
ShareUpdateExclusiveLock : AccessExclusiveLock;
if (reindexStmt->kind == REINDEX_OBJECT_INDEX) if (reindexStmt->kind == REINDEX_OBJECT_INDEX)
{ {
LOCKMODE lockmode = GetReindexIndexRelationLockMode(reindexStmt);
struct ReindexIndexCallbackState state; struct ReindexIndexCallbackState state;
state.concurrent = IsReindexWithParam_compat(reindexStmt, state.concurrent = IsReindexWithParam_compat(reindexStmt,
"concurrently"); "concurrently");
@ -571,6 +569,7 @@ ReindexStmtFindRelationOid(ReindexStmt *reindexStmt, bool missingOk)
} }
else else
{ {
LOCKMODE lockmode = GetReindexTableRelationLockMode(reindexStmt);
relationId = RangeVarGetRelidExtended(reindexStmt->relation, lockmode, relationId = RangeVarGetRelidExtended(reindexStmt->relation, lockmode,
(missingOk) ? RVR_MISSING_OK : 0, (missingOk) ? RVR_MISSING_OK : 0,
RangeVarCallbackOwnsTable, NULL); RangeVarCallbackOwnsTable, NULL);
@ -580,6 +579,35 @@ ReindexStmtFindRelationOid(ReindexStmt *reindexStmt, bool missingOk)
} }
/*
* GetReindexRelationLockMode returns required lock mode to open the
* index that given REINDEX INDEX command operates on.
*/
LOCKMODE
GetReindexIndexRelationLockMode(ReindexStmt *reindexStmt)
{
if (IsReindexWithParam_compat(reindexStmt, "concurrently"))
{
return ShareUpdateExclusiveLock;
}
else
{
return AccessExclusiveLock;
}
}
/*
* GetReindexTableLockMode returns required lock mode to open the
* relation that given REINDEX TABLE command operates on.
*/
LOCKMODE
GetReindexTableRelationLockMode(ReindexStmt *reindexStmt)
{
return ShareLock;
}
/* /*
* PreprocessReindexStmt determines whether a given REINDEX statement involves * PreprocessReindexStmt determines whether a given REINDEX statement involves
* a distributed table. If so (and if the statement does not use unsupported * a distributed table. If so (and if the statement does not use unsupported
@ -605,11 +633,11 @@ PreprocessReindexStmt(Node *node, const char *reindexCommand,
Oid relationId = ReindexStmtFindRelationOid(reindexStatement, false); Oid relationId = ReindexStmtFindRelationOid(reindexStatement, false);
MemoryContext relationContext = NULL; MemoryContext relationContext = NULL;
Relation relation = NULL; Relation relation = NULL;
LOCKMODE lockmode = IsReindexWithParam_compat(reindexStatement, "concurrently") ?
ShareUpdateExclusiveLock : AccessExclusiveLock;
if (reindexStatement->kind == REINDEX_OBJECT_INDEX) if (reindexStatement->kind == REINDEX_OBJECT_INDEX)
{ {
LOCKMODE lockmode = GetReindexIndexRelationLockMode(reindexStatement);
/* /*
* Acquire global lock to prevent concurrent writes or DDL. However, * Acquire global lock to prevent concurrent writes or DDL. However,
* we do not bother for REINDEX CONCURRENTLY, since we'll have * we do not bother for REINDEX CONCURRENTLY, since we'll have
@ -626,6 +654,8 @@ PreprocessReindexStmt(Node *node, const char *reindexCommand,
} }
else else
{ {
LOCKMODE lockmode = GetReindexTableRelationLockMode(reindexStatement);
AcquireDistributedLockOnRelations(list_make1(reindexStatement->relation), AcquireDistributedLockOnRelations(list_make1(reindexStatement->relation),
lockmode, 0); lockmode, 0);

2
src/include/distributed/commands.h
View File

@ -388,6 +388,8 @@ extern char * ChooseIndexName(const char *tabname, Oid namespaceId,
extern char * ChooseIndexNameAddition(List *colnames); extern char * ChooseIndexNameAddition(List *colnames);
extern List * ChooseIndexColumnNames(List *indexElems); extern List * ChooseIndexColumnNames(List *indexElems);
extern LOCKMODE GetCreateIndexRelationLockMode(IndexStmt *createIndexStatement); extern LOCKMODE GetCreateIndexRelationLockMode(IndexStmt *createIndexStatement);
extern LOCKMODE GetReindexTableRelationLockMode(ReindexStmt *reindexStmt);
extern LOCKMODE GetReindexIndexRelationLockMode(ReindexStmt *reindexStmt);
extern List * PreprocessReindexStmt(Node *ReindexStatement, extern List * PreprocessReindexStmt(Node *ReindexStatement,
const char *ReindexCommand, const char *ReindexCommand,
ProcessUtilityContext processUtilityContext); ProcessUtilityContext processUtilityContext);