Address reviews

velioglu/wo_seq_test_1
Burak Velioglu 2022-01-20 01:17:26 +03:00
parent 54f70e6e49
commit 3dbaf5886b
No known key found for this signature in database
GPG Key ID: F6827E620F6549C6
1 changed files with 7 additions and 5 deletions

View File

@ -84,7 +84,7 @@ char *EnableManualMetadataChangesForUser = "";
static void EnsureSequentialModeMetadataOperations(void); static void EnsureSequentialModeMetadataOperations(void);
static List * GetDistributedTableMetadataEvents(Oid relationId); static List * CitusTableMetadataCreateCommandList(Oid relationId);
static void EnsureObjectMetadataIsSane(int distributionArgumentIndex, static void EnsureObjectMetadataIsSane(int distributionArgumentIndex,
int colocationId); int colocationId);
static char * SchemaOwnerName(Oid objectId); static char * SchemaOwnerName(Oid objectId);
@ -643,11 +643,13 @@ DistributedObjectMetadataSyncCommandList(void)
/* /*
* GetDistributedTableMetadataEvents returns the full set of DDL commands necessary to * CitusTableMetadataCreateCommandList returns the set of commands necessary to
* create the given distributed table metadata on a worker. * create the given distributed table metadata on a worker. It includes truncate
* trigger as well, since we need to create truncate trigger for tables owned by
* extensions and use it for handling metadata while truncating tables.
*/ */
static List * static List *
GetDistributedTableMetadataEvents(Oid relationId) CitusTableMetadataCreateCommandList(Oid relationId)
{ {
CitusTableCacheEntry *cacheEntry = GetCitusTableCacheEntry(relationId); CitusTableCacheEntry *cacheEntry = GetCitusTableCacheEntry(relationId);
@ -1946,7 +1948,7 @@ CreateShellTableOnWorkers(Oid relationId)
void void
CreateTableMetadataOnWorkers(Oid relationId) CreateTableMetadataOnWorkers(Oid relationId)
{ {
List *commandList = GetDistributedTableMetadataEvents(relationId); List *commandList = CitusTableMetadataCreateCommandList(relationId);
/* prevent recursive propagation */ /* prevent recursive propagation */
SendCommandToWorkersWithMetadata(DISABLE_DDL_PROPAGATION); SendCommandToWorkersWithMetadata(DISABLE_DDL_PROPAGATION);