Address reviews

ref_on_buraks
Burak Velioglu 2022-01-27 10:54:24 +03:00
parent 7f7fd482fc
commit 6d4f70363e
No known key found for this signature in database
GPG Key ID: F6827E620F6549C6
2 changed files with 2 additions and 3 deletions

View File

@ -689,8 +689,8 @@ GenerateBackupNameForSequenceCollision(const ObjectAddress *address)
strncpy_s(newName + baseLength, NAMEDATALEN - baseLength, suffix, strncpy_s(newName + baseLength, NAMEDATALEN - baseLength, suffix,
suffixLength); suffixLength);
Oid typeOid = get_relname_relid(newName, schemaId); Oid newRelationId = get_relname_relid(newName, schemaId);
if (typeOid == InvalidOid) if (newRelationId == InvalidOid)
{ {
return newName; return newName;
} }

View File

@ -706,7 +706,6 @@ SupportedDependencyByCitus(const ObjectAddress *address)
/* /*
* IsTableOwnedByExtension returns whether the table with the given relation ID is * IsTableOwnedByExtension returns whether the table with the given relation ID is
* owned by an extension. * owned by an extension.
* TODO: Check what if the extension is not distributed?
*/ */
bool bool
IsTableOwnedByExtension(Oid relationId) IsTableOwnedByExtension(Oid relationId)